falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Re: Review Request 24701: delete test dir if clean_test_dir=true
Date Tue, 26 Aug 2014 17:01:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24701/#review51540
-----------------------------------------------------------



falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
<https://reviews.apache.org/r/24701/#comment89949>

    During one of the discussion we had decided that BaseTestClass will not have any @AfterClass,
@BeforeClass or other tags.
    https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/merlin-falconqa/04_kyMhDq4c/MAe0k8bCtKsJ
    
    To reiterate an example where this can lead to problems.
    1. we create test data as user1
    2. switch to user2 for testing
    3. @AfterClass tagged method cleanTestDirs is called. Since, the curret user is user2
- this will fail.
    
    The basic issue is that there is no gurantees as the order in which @AfterClass tagged
methods will called. So, we had decided that we will keep all the tagged methods in child/test
classes. And not use them in BaseTestClass. We also followed this for removeBundles() method.


- Raghav Gautam


On Aug. 26, 2014, 7:08 a.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24701/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2014, 7:08 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> We can leave input data after tests for debug. Input data will be deleted if we run tests
again in @BeforeMethod (during HadoopUtil.flattenAndPutDataInFolder()).
> To leave data Merline.properties should contains clean_test_dir=false
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java
3c6779f 
>   falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
c64ddad 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java
d728d13 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java
bf0e8d3 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
515b18e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java
8b40cf1 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java
6bcb24a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java
559df48 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java
e77d534 
> 
> Diff: https://reviews.apache.org/r/24701/diff/
> 
> 
> Testing
> -------
> 
> NoOutputProcessTest with true/false
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message