falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Isaychuk" <pisayc...@hortonworks.com>
Subject Re: Review Request 24514: Refactor code for cross product and make it a method
Date Thu, 14 Aug 2014 14:38:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24514/#review50579
-----------------------------------------------------------

Ship it!


+1 from my side.

- Paul Isaychuk


On Aug. 8, 2014, 11:18 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24514/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2014, 11:18 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-581
>     https://issues.apache.org/jira/browse/falcon-581
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> There are multiple occurrences of cross product code. This patch tries to unify it and
expose it as a method.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java
PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java
65cf14e 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
1d5fb1d 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java
8156937 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
c8cef02 
> 
> Diff: https://reviews.apache.org/r/24514/diff/
> 
> 
> Testing
> -------
> 
> All the tests that use this method have been run.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message