falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghav Gautam" <raghavgau...@gmail.com>
Subject Review Request 24354: Align falcon-regression code with falcon codebase
Date Tue, 05 Aug 2014 23:34:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24354/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-564
    https://issues.apache.org/jira/browse/FALCON-564


Repository: falcon-git


Description
-------

This patch tries to remove redundant code of falcon regression. It also cleans up parts of
pom of falcon-regression and align it with falcon.


Diffs
-----

  falcon-regression/merlin-core/pom.xml 9cac189 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/DateValidator.java
e9cdd87 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/Entity.java 252e860

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/EntityType.java
e93fb49 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/Frequency.java a9e4b90

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java
62b810c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Cluster.java
0a097dc 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Interface.java
1b6be3e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Interfaces.java
2cf0ea6 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Interfacetype.java
f05ed07 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Location.java
bc07315 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Locations.java
0988dc3 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/ObjectFactory.java
8222988 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Properties.java
66cc5cf 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/Property.java
fd35145 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/cluster/package-info.java
dc21e24 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/ACL.java ebaf70a

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/ActionType.java
57380e7 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Adapter1.java
c11541b 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Adapter2.java
98fe47d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Adapter3.java
81c3c1e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/CatalogTable.java
c942f8a 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Cluster.java
0c295cb 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/ClusterType.java
a996c19 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Clusters.java
c2750eb 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Feed.java 7faa1dc

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/LateArrival.java
d4f62df 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Location.java
c3f3461 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/LocationType.java
52989db 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Locations.java
a67ac6b 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/ObjectFactory.java
b973bea 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Partition.java
4958d37 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Partitions.java
5c05103 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Properties.java
44aa10c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Property.java
70e16dc 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Retention.java
b811199 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/RetentionType.java
9603c29 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Schema.java
021113f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/Validity.java
a2f443f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/feed/package-info.java
a877a37 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Adapter1.java
e0a3431 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Adapter2.java
b344507 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Adapter3.java
5a88f3d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Cluster.java
b48ea36 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Clusters.java
fff855e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/EngineType.java
a1fb16f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/ExecutionType.java
58c9bcb 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Input.java
85e2910 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Inputs.java
46c8263 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/LateInput.java
6be03e1 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/LateProcess.java
d9b01e1 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/ObjectFactory.java
de01268 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Output.java
8fee1db 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Outputs.java
bd865f1 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/PolicyType.java
1e3c2fa 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Process.java
fec9521 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Properties.java
5b0020e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Property.java
794a1a7 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Retry.java
07eabba 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Validity.java
1b013a3 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/Workflow.java
e546836 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/entity/v0/process/package-info.java
f68ce95 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
182f36e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
11d3fb0 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
b9db07e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java
PRE-CREATION 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
84ecb9c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java
789a256 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
184c7db 
  falcon-regression/merlin/pom.xml f874157 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
c524324 
  falcon-regression/pom.xml 0763238 

Diff: https://reviews.apache.org/r/24354/diff/


Testing
-------

1. Manually tested changes by clearing maven cache, installing falcon jars locally and running
RetentionTest#testRetentionWithEmptyDirectories
2. For changes that switch to *Merlin - ran InstanceSummaryTest, InstanceSummaryTest#testSummaryMultiClusterFeed,
FeedRetentionTest, EmbeddedPigScriptTest


Thanks,

Raghav Gautam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message