falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-507) HiveCatalogService has hardcode the database name "default" to check whether the service is up.
Date Mon, 28 Jul 2014 21:33:38 GMT

    [ https://issues.apache.org/jira/browse/FALCON-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076919#comment-14076919
] 

Sushanth Sowmyan commented on FALCON-507:
-----------------------------------------

I would agree, "show databases" is probably a better test. As long as you don't get an exception
from that call, you're good.

> HiveCatalogService has hardcode the database name "default" to check whether the service
is up. 
> ------------------------------------------------------------------------------------------------
>
>                 Key: FALCON-507
>                 URL: https://issues.apache.org/jira/browse/FALCON-507
>             Project: Falcon
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>              Labels: hive
>             Fix For: 0.6
>
>
> Don Bosco Durai reported in an email to me:
> While debugging the issue, it seems HiveCatalogService has hardcode the database name
"default" to check whether the service is up. I think this check will fail if the customer
has dropped the database "default" in production.
> {code}
> @Override
>     public boolean isAlive(final String catalogUrl,
>                            final String metaStorePrincipal) throws FalconException {
>         LOG.info("Checking if the service is alive for: " + catalogUrl);
>         try {
>             HCatClient client = getProxiedClient(catalogUrl, metaStorePrincipal);
>             HCatDatabase database = client.getDatabase("default");
>             return database != null;
>         } catch (HCatException e) {
>             throw new FalconException("Exception checking if the service is alive:" +
e.getMessage(), e);
>         }
>     }
> {code}
> Thanks Bosco.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message