Return-Path: 
 <dev-return-4439-apmail-falcon-dev-archive=falcon.apache.org@falcon.incubator.apache.org>
X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org
Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1A28F11459
	for <apmail-falcon-dev-archive@minotaur.apache.org>;
 Fri, 27 Jun 2014 22:33:49 +0000 (UTC)
Received: (qmail 91600 invoked by uid 500); 27 Jun 2014 22:33:48 -0000
Delivered-To: apmail-falcon-dev-archive@falcon.apache.org
Received: (qmail 91560 invoked by uid 500); 27 Jun 2014 22:33:48 -0000
Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@falcon.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@falcon.incubator.apache.org>
List-Post: <mailto:dev@falcon.incubator.apache.org>
List-Id: <dev.falcon.incubator.apache.org>
Reply-To: dev@falcon.incubator.apache.org
Delivered-To: mailing list dev@falcon.incubator.apache.org
Received: (qmail 91549 invoked by uid 99); 27 Jun 2014 22:33:48 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 22:33:48 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Jun 2014 22:33:50 +0000
Received: (qmail 91069 invoked by uid 99); 27 Jun 2014 22:33:25 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 22:33:25 +0000
Date: Fri, 27 Jun 2014 22:33:25 +0000 (UTC)
From: "Shaik Idris Ali (JIRA)" <jira@apache.org>
To: dev@falcon.incubator.apache.org
Message-ID: <JIRA.12723066.1403499429495.64933.1403908405039@arcas>
In-Reply-To: <JIRA.12723066.1403499429495@arcas>
References: <JIRA.12723066.1403499429495@arcas>
Subject: [jira] [Commented] (FALCON-485) Simplify JMS Message
 Sender/Consumer and use Workflow Context
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/FALCON-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046484#comment-14046484 ] 

Shaik Idris Ali commented on FALCON-485:
----------------------------------------

* Same fix here
{code}
    public String getValue(WorkflowExecutionArgs arg, String defaultValue) {
        return context.containsKey(arg) ? context.get(arg.getName()) : defaultValue;
    }
{code}

* I think this is FalconTopicSubscriber is renamed and moved to Messaging, the idea of keeping messaging separate was the jar was shipped with scheduled entity, but FalconTopicSubscriber is actually part of Falcon server and listens to topic. 

* WorkflowJobEndNotificationService.instrumentAlert() needs WorkflowEngineFactory.getWorkflowEngine(),  this dependency is missing in pom.xml
Looks like cyclic dependency of common and oozie-adaptor module ?
{code}
        <dependency>
            <groupId>org.apache.falcon</groupId>
            <artifactId>falcon-oozie-adaptor</artifactId>
        </dependency>
{code}

* Can we add Assert.Fail by adding try/catch in JMSMessageConsumerTest.testSubscriber()'s Exception block. All the exceptions in the thread are ignored.

> Simplify JMS Message Sender/Consumer and use Workflow Context
> -------------------------------------------------------------
>
>                 Key: FALCON-485
>                 URL: https://issues.apache.org/jira/browse/FALCON-485
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: messaging
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: refactoring
>             Fix For: 0.6
>
>         Attachments: FALCON-485.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)