Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.incubator.apache.org
Date: Wed, 18 Jun 2014 06:22:02 +0000 (UTC)
From: "Srikanth Sundarrajan (JIRA)" <jira@apache.org>
To: dev@falcon.incubator.apache.org
Message-ID: <JIRA.12702862.1395407556677.152040.1403072522615@arcas>
In-Reply-To: <JIRA.12702862.1395407556677@arcas>
References: <JIRA.12702862.1395407556677@arcas>
Subject: [jira] [Commented] (FALCON-369) Refactor workflow builder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FALCON-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034868#comment-14034868 ] 

Srikanth Sundarrajan commented on FALCON-369:
---------------------------------------------

Thanks. Looks largely fine. Few observations though

1. buildCoords in FeedRetention/Replication & Process are still concerning themselves with extracting tasks from the entity, which we need to move out. Perhaps you can add a TODO to accommodate that in FALCON-126.

2. Some functions like HiveCred/Conf are repeated across concrete classes, perhaps they can be moved to a utility class

3. A doc showing the hierarchy of classes and how they collaborate would be very helpful.

Am assuming these changes are fully backward compatible. If there are any aspects that weren't tested with this refactoring, it might be useful to callout or to even create tracking JIRAs.

Thanks for taking this massive refactoring exercise.

> Refactor workflow builder
> -------------------------
>
>                 Key: FALCON-369
>                 URL: https://issues.apache.org/jira/browse/FALCON-369
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>         Attachments: FALCON-369-v2.patch, FALCON-369.patch, FalconWorkflowBuilder.png
>
>
> Currently, feed/process workflow builder is a single class which handles all different cases of lifecycles, storage types, workflow engines and building all oozie entities(workflow, coord and bundle). This is not readable and difficult to maintain. This needs some re-factoring.
> Approach:
> Maintain different builders for
> 1. oozie entities - workflow, coord and bundle. 
> 2. entity types - feed and process
> 3. lifecycle - process, retention and replication
> 4. workflow engines - oozie, pig and hive


--
This message was sent by Atlassian JIRA
(v6.2#6252)