falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaik Idris Ali (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-485) Simplify JMS Message Sender/Consumer and use Workflow Context
Date Fri, 27 Jun 2014 22:33:25 GMT

    [ https://issues.apache.org/jira/browse/FALCON-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046484#comment-14046484
] 

Shaik Idris Ali commented on FALCON-485:
----------------------------------------

* Same fix here
{code}
    public String getValue(WorkflowExecutionArgs arg, String defaultValue) {
        return context.containsKey(arg) ? context.get(arg.getName()) : defaultValue;
    }
{code}

* I think this is FalconTopicSubscriber is renamed and moved to Messaging, the idea of keeping
messaging separate was the jar was shipped with scheduled entity, but FalconTopicSubscriber
is actually part of Falcon server and listens to topic. 

* WorkflowJobEndNotificationService.instrumentAlert() needs WorkflowEngineFactory.getWorkflowEngine(),
 this dependency is missing in pom.xml
Looks like cyclic dependency of common and oozie-adaptor module ?
{code}
        <dependency>
            <groupId>org.apache.falcon</groupId>
            <artifactId>falcon-oozie-adaptor</artifactId>
        </dependency>
{code}

* Can we add Assert.Fail by adding try/catch in JMSMessageConsumerTest.testSubscriber()'s
Exception block. All the exceptions in the thread are ignored.

> Simplify JMS Message Sender/Consumer and use Workflow Context
> -------------------------------------------------------------
>
>                 Key: FALCON-485
>                 URL: https://issues.apache.org/jira/browse/FALCON-485
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: messaging
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: refactoring
>             Fix For: 0.6
>
>         Attachments: FALCON-485.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message