falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-483) Fix the failing test ConfigurationStoreTest.testConcurrentRemoves on jenkins
Date Mon, 30 Jun 2014 21:21:25 GMT

    [ https://issues.apache.org/jira/browse/FALCON-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048178#comment-14048178
] 

Shwetha G S commented on FALCON-483:
------------------------------------

{code}
+    public void testConcurrentRemoveOfSameProcess() throws Exception {
+        store.remove(EntityType.PROCESS, PROCESS1NAME);
+        Process p = store.get(EntityType.PROCESS, PROCESS1NAME);
         Assert.assertNull(p);
     }
 
+    @Test(threadPoolSize = 3, invocationCount = 6)
+    public void testConcurrentRemove() throws Exception {
+        store.remove(EntityType.PROCESS, PROCESS2NAME);
+        Process p1 = store.get(EntityType.PROCESS, PROCESS2NAME);
+        Assert.assertNull(p1);
+
+        store.remove(EntityType.PROCESS, PROCESS3NAME);
+        Process p2 = store.get(EntityType.PROCESS, PROCESS3NAME);
+        Assert.assertNull(p2);
+    }
+
{code}
Is the 2nd test required? Isn't it same as the first?

> Fix the failing test ConfigurationStoreTest.testConcurrentRemoves on jenkins 
> -----------------------------------------------------------------------------
>
>                 Key: FALCON-483
>                 URL: https://issues.apache.org/jira/browse/FALCON-483
>             Project: Falcon
>          Issue Type: Bug
>            Reporter: Sowmya Ramesh
>         Attachments: FALCON-483.patch, FALCON-483.v2.patch
>
>
> Running org.apache.falcon.entity.store.ConfigurationStoreTest
> Tests run: 9, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 4.838 sec <<<
FAILURE! - in org.apache.falcon.entity.store.ConfigurationStoreTest
> testConcurrentRemoves(org.apache.falcon.entity.store.ConfigurationStoreTest)  Time elapsed:
0.052 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> <process name="remove" xmlns="uri:falcon:process:0.1">
>     <parallel>0</parallel>
> </process>
> > but was:<null>
> 	at org.testng.Assert.fail(Assert.java:89)
> 	at org.testng.Assert.failNotEquals(Assert.java:489)
> 	at org.testng.Assert.assertEquals(Assert.java:118)
> 	at org.testng.Assert.assertEquals(Assert.java:160)
> 	at org.apache.falcon.entity.store.ConfigurationStoreTest.testConcurrentRemoves(ConfigurationStoreTest.java:130)
> testConcurrentRemoves(org.apache.falcon.entity.store.ConfigurationStoreTest)  Time elapsed:
0.052 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> <process name="remove" xmlns="uri:falcon:process:0.1">
>     <parallel>0</parallel>
> </process>
> > but was:<null>
> 	at org.testng.Assert.fail(Assert.java:89)
> 	at org.testng.Assert.failNotEquals(Assert.java:489)
> 	at org.testng.Assert.assertEquals(Assert.java:118)
> 	at org.testng.Assert.assertEquals(Assert.java:160)
> 	at org.apache.falcon.entity.store.ConfigurationStoreTest.testConcurrentRemoves(ConfigurationStoreTest.java:130)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message