falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-133) Upgrade to slf4j 1.7.5 and use SLF4J logger
Date Sat, 10 May 2014 22:07:13 GMT

    [ https://issues.apache.org/jira/browse/FALCON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992719#comment-13992719
] 

Shwetha G S commented on FALCON-133:
------------------------------------

I thought I could commit this and MDC can be done as part of another jira. But the patch doesn't
apply with git apply and it doesn't compile. Can you check:
{noformat}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile
(default-compile) on project falcon-common: Compilation failure: Compilation failure:
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java:[317,15]
cannot find symbol
[ERROR] symbol  : method error(java.lang.String,org.apache.falcon.entity.v0.EntityType,java.lang.String,javax.xml.bind.JAXBException)
[ERROR] location: interface org.slf4j.Logger
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/cleanup/AbstractCleanupHandler.java:[125,19]
cannot find symbol
[ERROR] symbol  : method info(java.lang.String,long,long,org.apache.hadoop.fs.Path)
[ERROR] location: interface org.slf4j.Logger
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java:[115,11]
cannot find symbol
[ERROR] symbol  : method info(java.lang.String,java.lang.String,org.apache.falcon.metadata.RelationshipType,com.tinkerpop.blueprints.Vertex)
[ERROR] location: interface org.slf4j.Logger
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java:[165,15]
cannot find symbol
[ERROR] symbol  : method info(java.lang.String,java.lang.String,java.lang.String,java.lang.String)
[ERROR] location: interface org.slf4j.Logger
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/cleanup/FeedCleanupHandler.java:[54,23]
cannot find symbol
[ERROR] symbol  : method info(java.lang.String,java.lang.String,java.lang.String,long)
[ERROR] location: interface org.slf4j.Logger
[ERROR] /work/git/falcon-clone/common/src/main/java/org/apache/falcon/cleanup/ProcessCleanupHandler.java:[47,23]
cannot find symbol
[ERROR] symbol  : method info(java.lang.String,java.lang.String,java.lang.String,long)
[ERROR] location: interface org.slf4j.Logger
{noformat}

> Upgrade to slf4j 1.7.5 and use SLF4J logger
> -------------------------------------------
>
>                 Key: FALCON-133
>                 URL: https://issues.apache.org/jira/browse/FALCON-133
>             Project: Falcon
>          Issue Type: Improvement
>          Components: general
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>         Attachments: FALCON-133.patch
>
>
> SLF4J 1.7.5 provides interesting performance improvements.
> More over, it's not more require to test the log level, we can use directly {} in the
message formatter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message