falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 21857: Added option to display wf-params for a given instance
Date Fri, 23 May 2014 12:33:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/#review43826
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java
<https://reviews.apache.org/r/21857/#comment78114>

    Don't define another sendInstanceRequest()
    
    Assert that there is just <=1 lifecycle
    



client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java
<https://reviews.apache.org/r/21857/#comment78115>

    Not required



common/src/main/java/org/apache/falcon/entity/EntityUtil.java
<https://reviews.apache.org/r/21857/#comment78116>

    Not required. Use EntityUtil.getNextStartTime()


- shwethags


On May 23, 2014, 11:57 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21857/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 11:57 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Adding params option which will display all wf-params for a given instance
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f 
>   client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c 
>   client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
c28cb03 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0

>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469

>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb

>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27 
> 
> Diff: https://reviews.apache.org/r/21857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message