falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-280) Validate the ACL in entity with the user submitting the entity
Date Wed, 09 Apr 2014 10:32:37 GMT

    [ https://issues.apache.org/jira/browse/FALCON-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964005#comment-13964005
] 

Srikanth Sundarrajan commented on FALCON-280:
---------------------------------------------

{code}
+                        throw new FalconException("ACL doesn't match on " + location.getPath());

{code}
Might be useful to log the current permission and the feed's ACL for debugging purposes. Also
the exception could include these details to help the users debug and resolve issues quickly.

{code}
+            storage.validateACL(feed.getACL().getOwner(), feed.getACL().getGroup(), feed.getACL().getPermission());
{code}
Minor nit: Perhaps feed.getACL() could be stored and used, instead of invoking it for each
arg.

Looks good other wise.


> Validate the ACL in entity with the user submitting the entity
> --------------------------------------------------------------
>
>                 Key: FALCON-280
>                 URL: https://issues.apache.org/jira/browse/FALCON-280
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: feed
>            Reporter: Venkatesh Seetharam
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.5
>
>         Attachments: FALCON-280.patch
>
>
> Also, validate if the user has permissions for storage specified.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message