falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shwetha G S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-133) Upgrade to slf4j 1.7.5 and use SLF4J logger
Date Thu, 24 Apr 2014 13:58:16 GMT

    [ https://issues.apache.org/jira/browse/FALCON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979742#comment-13979742
] 

Shwetha G S commented on FALCON-133:
------------------------------------

Some minor comments. Looks good otherwise. Will commit once even MDC changes are done. This
touches a lot of code. Thanks for taking it up
{noformat}
-            LOG.error("Error in parsing broker.ttl, setting TTL to:"
-                    + DEFAULT_TTL + " milli-seconds");
+            LOG.error("Error in parsing broker.ttl, setting TTL to: {} milli-seconds",
+                    DEFAULT_TTL + " milli-seconds");
{noformat}
milli-seconds is repeated

{noformat}
-        LOG.info(buffer);
+        LOG.info(buffer.toString());
{noformat}
This should be LOG.info(buffer)? Why evaluate toString() as call?

{noformat}
-        LOG.debug("Enqueued Message:" + event.toString());
+        LOG.debug("Enqueued Message: {}", event.toString());
-            LOG.debug("Dequeued Message:" + event.toString());
+            LOG.debug("Dequeued Message: {}", event.toString());
{noformat}
This should be LOG.debug("Enqueued Message:" + event)?

{noformat}
-        clusterEntity.setDescription("Embeded cluster: " + name);
+        clusterEntity.setDescription("Embedded cluster: " + name);
{noformat}
missed?


> Upgrade to slf4j 1.7.5 and use SLF4J logger
> -------------------------------------------
>
>                 Key: FALCON-133
>                 URL: https://issues.apache.org/jira/browse/FALCON-133
>             Project: Falcon
>          Issue Type: Improvement
>          Components: general
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>         Attachments: FALCON-133.patch
>
>
> SLF4J 1.7.5 provides interesting performance improvements.
> More over, it's not more require to test the log level, we can use directly {} in the
message formatter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message