falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed doesn't give the retention details
Date Wed, 23 Apr 2014 08:14:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review41123
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment74531>

    Since tag already contains entity type, entity type can be removed from here



client/src/main/java/org/apache/falcon/LifeCycle.java
<https://reviews.apache.org/r/19096/#comment74532>

    fromEntityType() and fromTag() are not required



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment74533>

    This should use valueOf()



common/src/main/java/org/apache/falcon/entity/EntityUtil.java
<https://reviews.apache.org/r/19096/#comment74534>

    move to OozieWorkflowEngine



docs/src/site/twiki/FalconCLI.twiki
<https://reviews.apache.org/r/19096/#comment74535>

    typo - cane
    
    Mention that its list f lifecycle



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment74536>

    There shouldn't be any special handling for retention. AbstractEntityManager should set
the default lifecycle if lifecycle is not set. The workflow engine should just check that
the tag in the workflow engine is one of the specified lifecycles.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment74537>

    Instead of checking for retention, check if coord name tag contains one of lifecycles



prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/19096/#comment74540>

    set default values for lifecycle if null


- shwethags


On April 22, 2014, 10:59 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 10:59 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-240
>     https://issues.apache.org/jira/browse/FALCON-240
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Added lifecycle option in falcon which is used to view the retention details of feed
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 33f52c4 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 5d9701f 
>   client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 9061a9e 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
f700b8f 
>   docs/src/site/twiki/FalconCLI.twiki 149aaa3 
>   docs/src/site/twiki/restapi/InstanceKill.twiki eff2893 
>   docs/src/site/twiki/restapi/InstanceLogs.twiki 599f2d7 
>   docs/src/site/twiki/restapi/InstanceRerun.twiki 77608e0 
>   docs/src/site/twiki/restapi/InstanceResume.twiki 2d29569 
>   docs/src/site/twiki/restapi/InstanceRunning.twiki 116565f 
>   docs/src/site/twiki/restapi/InstanceStatus.twiki 99497d1 
>   docs/src/site/twiki/restapi/InstanceSummary.twiki bd1d2e5 
>   docs/src/site/twiki/restapi/InstanceSuspend.twiki 8f5f7c3 
>   hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509

>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 9d4103b

>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc

>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a

>   test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93

>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b6c5054 
> 
> Diff: https://reviews.apache.org/r/19096/diff/
> 
> 
> Testing
> -------
> 
> There are Unit test cases for this.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message