Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B165710B93 for ; Tue, 18 Mar 2014 05:49:01 +0000 (UTC) Received: (qmail 10088 invoked by uid 500); 18 Mar 2014 05:49:01 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 9993 invoked by uid 500); 18 Mar 2014 05:48:59 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 9984 invoked by uid 99); 18 Mar 2014 05:48:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 05:48:56 +0000 X-ASF-Spam-Status: No, hits=-1996.6 required=5.0 tests=ALL_TRUSTED,FORGED_HOTMAIL_RCVD2,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 18 Mar 2014 05:48:53 +0000 Received: (qmail 9648 invoked by uid 99); 18 Mar 2014 05:48:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 05:48:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 377211D54A6; Tue, 18 Mar 2014 05:48:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2040677686226296765==" MIME-Version: 1.0 Subject: Re: Review Request 19286: FALCON-356 Merge OozieProcessMapper and OozieProcessWorkflowBuilder From: "Srikanth Sundarrajan" To: shwetha.gs@inmobi.com, "Falcon" , "Srikanth Sundarrajan" Date: Tue, 18 Mar 2014 05:48:27 -0000 Message-ID: <20140318054827.15795.65242@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Srikanth Sundarrajan" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/19286/ X-Sender: "Srikanth Sundarrajan" References: <20140317095025.17334.53138@reviews.apache.org> In-Reply-To: <20140317095025.17334.53138@reviews.apache.org> Reply-To: "Srikanth Sundarrajan" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============2040677686226296765== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19286/#review37535 ----------------------------------------------------------- common/src/main/java/org/apache/falcon/util/ReflectionUtils.java Should constructor args be var-args instead ? common/src/main/java/org/apache/falcon/util/ReflectionUtils.java What if arg is null ? feed/src/main/java/org/apache/falcon/workflow/OozieFeedWorkflowBuilder.java Why does the log say process validity ? Isn't this feed workflow builder ? feed/src/main/java/org/apache/falcon/workflow/OozieFeedWorkflowBuilder.java Dont we need to check for replicationCoord being null ? feed/src/main/java/org/apache/falcon/workflow/OozieFeedWorkflowBuilder.java Why are the retention mapper & replication mapper returning coord / workflows etc. Can we keep their behavior consistent, it is quite useful in following the code - Srikanth Sundarrajan On March 17, 2014, 9:50 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19286/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 9:50 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > There is one to one mapping between OozieProcessMapper and OozieProcessWorkflowBuilder. Entity to oozie workflow mapping is spread across these two classes. Same goes for OozieFeedMapper and OozieFeedWorkflowBuilder. > > modified: common/src/main/java/org/apache/falcon/util/ReflectionUtils.java > modified: common/src/main/java/org/apache/falcon/workflow/WorkflowBuilder.java > renamed: feed/src/main/java/org/apache/falcon/converter/OozieFeedMapper.java -> feed/src/main/java/org/apache/falcon/workflow/OozieFeedWorkflowBuilder.java > renamed: feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java -> feed/src/test/java/org/apache/falcon/converter/OozieFeedWorkflowBuilderTest.java > modified: oozie/src/main/java/org/apache/falcon/util/OozieUtils.java > renamed: oozie/src/main/java/org/apache/falcon/converter/AbstractOozieEntityMapper.java -> oozie/src/main/java/org/apache/falcon/workflow/OozieWorkflowBuilder.java > modified: oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > renamed: process/src/main/java/org/apache/falcon/converter/OozieProcessMapper.java -> process/src/main/java/org/apache/falcon/workflow/OozieProcessWorkflowBuilder.java > deleted: process/src/test/java/org/apache/falcon/converter/OozieProcessMapperLateProcessTest.java > renamed: process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java -> process/src/test/java/org/apache/falcon/converter/OozieProcessWorkflowBuilderTest.java > modified: retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/ReflectionUtils.java 4a00fa9 > common/src/main/java/org/apache/falcon/workflow/WorkflowBuilder.java 26243e7 > feed/src/main/java/org/apache/falcon/converter/OozieFeedMapper.java 2b3315f > feed/src/main/java/org/apache/falcon/workflow/OozieFeedWorkflowBuilder.java 5e3a30e > feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java e610df2 > feed/src/test/java/org/apache/falcon/converter/OozieFeedWorkflowBuilderTest.java PRE-CREATION > oozie/src/main/java/org/apache/falcon/converter/AbstractOozieEntityMapper.java f443939 > oozie/src/main/java/org/apache/falcon/util/OozieUtils.java 2f53370 > oozie/src/main/java/org/apache/falcon/workflow/OozieWorkflowBuilder.java e5a01ca > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java ac8862e > process/src/main/java/org/apache/falcon/converter/OozieProcessMapper.java e638961 > process/src/main/java/org/apache/falcon/workflow/OozieProcessWorkflowBuilder.java 4e5e8c6 > process/src/test/java/org/apache/falcon/converter/OozieProcessMapperLateProcessTest.java fbda0ea > process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 22bf9fe > process/src/test/java/org/apache/falcon/converter/OozieProcessWorkflowBuilderTest.java PRE-CREATION > retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java 1e7cc04 > > Diff: https://reviews.apache.org/r/19286/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > > --===============2040677686226296765==--