falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-378) Feed status fails with NPE post update when the new coordinator is in PREP state
Date Wed, 26 Mar 2014 05:06:15 GMT

    [ https://issues.apache.org/jira/browse/FALCON-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947555#comment-13947555
] 

Venkatesh Seetharam commented on FALCON-378:
--------------------------------------------

This could well be in addition to filtering the PREP state, no? The reason being there are
NO actions for the coord in PREP state and there is no point in even invoking the nextMatTime
on this coord.

Will revise the patch with null check as well. [~shwethags], are you ok with this or you think
this is unnecessary. 


> Feed status fails with NPE post update when the new coordinator is in PREP state
> --------------------------------------------------------------------------------
>
>                 Key: FALCON-378
>                 URL: https://issues.apache.org/jira/browse/FALCON-378
>             Project: Falcon
>          Issue Type: Bug
>          Components: oozie
>    Affects Versions: 0.4
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: oozie
>         Attachments: FALCON-378.patch, oozie-coord-new.tiff, oozie-coords.tiff, test-update-feed-1.xml,
test-update-feed-2.xml, test-update-feed.xml
>
>
> An NPE is thrown for status calls post feed update briefly between the new coord creation
transitioning from PREP to RUNNING at:
> {code}
> org.apache.falcon.workflow.engine.OozieWorkflowEngine#getCoordActions
>                 Date iterEnd = (coord.getNextMaterializedTime().before(end) ? coord.getNextMaterializedTime()
: end);
> {code}
> coord.getNextMaterializedTime() is null since the coord is in PREP state as the new coord's
effective time is set as now() + 3 min. In reality, this is greater than 3 mins is my observation.
> {code}
> Feed updated at:
> Current time = Tue, 25 Mar 2014 21:54:00 GMT
> Old Coord: 
> Start time = Tue, 25 Mar 2014 00:00:00 GMT
> End time = Tue, 25 Mar 2014 22:00:00 GMT
> Status = RUNNING
> New Coord:
> Start time =  Tue, 25 Mar 2014 22:00:00 GMT
> End time = Wed, 26 Mar 2014 00:00:00 GMT
> Status = PREP
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message