falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suhas Vasu" <suhas....@gmail.com>
Subject Re: Review Request 19096: FALCON-240 Instance status from CLI on a feed doesn't give the retention details
Date Thu, 13 Mar 2014 09:34:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19096/#review37039
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/19096/#comment68298>

    you should print 'lifecycle' rather than 'lifeCycles'



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/19096/#comment68297>

    function name is bit misleading, you may want to rename it


- Suhas  Vasu


On March 12, 2014, 11:14 a.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19096/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 11:14 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-240
>     https://issues.apache.org/jira/browse/FALCON-240
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Added lifecycle option in falcon which is used to view the retention details of feed
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/LifeCycle.java PRE-CREATION 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java c8ce780 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java f008953 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d 
>   common/src/main/java/org/apache/falcon/hadoop/HadoopClientFactory.java d5fbda8 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
f700b8f 
>   hadoop-dependencies/src/main/java/org/apache/falcon/hadoop/JailedFileSystem.java e12a509

>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java dee77c0

>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 07ab2bc

>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 407f39a

>   test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java af29f93

>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java fd3cd51 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 5cd7beb 
> 
> Diff: https://reviews.apache.org/r/19096/diff/
> 
> 
> Testing
> -------
> 
> There are Unit test cases for this.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message