Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B098F108F0 for ; Thu, 30 Jan 2014 06:00:42 +0000 (UTC) Received: (qmail 96023 invoked by uid 500); 30 Jan 2014 06:00:42 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 96001 invoked by uid 500); 30 Jan 2014 06:00:41 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 95993 invoked by uid 99); 30 Jan 2014 06:00:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jan 2014 06:00:41 +0000 X-ASF-Spam-Status: No, hits=-1997.1 required=5.0 tests=ALL_TRUSTED,FORGED_HOTMAIL_RCVD2,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 30 Jan 2014 06:00:39 +0000 Received: (qmail 95804 invoked by uid 99); 30 Jan 2014 06:00:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jan 2014 06:00:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9994A1C07A4; Thu, 30 Jan 2014 06:00:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6287240568296563194==" MIME-Version: 1.0 Subject: Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI From: "Srikanth Sundarrajan" To: "Falcon" , "Srikanth Sundarrajan" Date: Thu, 30 Jan 2014 06:00:17 -0000 Message-ID: <20140130060017.21444.72888@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Srikanth Sundarrajan" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/17525/ X-Sender: "Srikanth Sundarrajan" References: <20140130054815.21444.29207@reviews.apache.org> In-Reply-To: <20140130054815.21444.29207@reviews.apache.org> Reply-To: "Srikanth Sundarrajan" X-ReviewRequest-Repository: falcon-git X-Virus-Checked: Checked by ClamAV on apache.org --===============6287240568296563194== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17525/#review33201 ----------------------------------------------------------- client/src/main/java/org/apache/falcon/cli/FalconCLI.java Can this switch be called effectiveTime instead prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java REST query param can also be called effectiveTime webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java time to effectiveTime webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java Looks like this function isn't being used. Dont know what is the impact of changing the end time to the first hour of the day to the first day of the month. - Srikanth Sundarrajan On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17525/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 5:48 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-264 > https://issues.apache.org/jira/browse/FALCON-264 > > > Repository: falcon-git > > > Description > ------- > > Update with effective time in CLI > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e > client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java 025e1b7 > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425 > pom.xml 9252d80 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java bbb1120 > webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf > > Diff: https://reviews.apache.org/r/17525/diff/ > > > Testing > ------- > > > Thanks, > > Srikanth Sundarrajan > > --===============6287240568296563194==--