falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-220) Post processing should propagate user information in messages for offline processing
Date Thu, 16 Jan 2014 17:56:27 GMT

    [ https://issues.apache.org/jira/browse/FALCON-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873669#comment-13873669
] 

Venkatesh Seetharam commented on FALCON-220:
--------------------------------------------

Thanks [~shaik.idris] for taking time to review. My comments are below.

bq. Will this be backward compatible? When we upgrade Falcon, the older scheduled workflows
will not send workflowUser.
This is a very good question. The current implementation is not backwards compatible.

I have a fundamental question here. Before we think about compatibility in Falcon, are oozie
workflows backwards compatible when migrating workflows from an non-secure oozie to secure
oozie. If so, we should be able to address this.

Since there is a call made to Oozie in org.apache.falcon.service.FalconTopicSubscriber#onMessage,
we should be able to get the workflow user there but I'd rather avoid a round trip to Oozie
and get it in the message. We are getting start and end time, start could have been sent in
the message.
 
bq. So, "null" user in LateDataHandler and RetryHandler should be fine?
It wont even get that far. You'd get an Illegal state exception with
{code}
            CurrentUser.authenticate(workflowUser);
{code}

bq. Also, one checkstyle issue:
If you apply the dependent patches in order, you'd not get this. This is specifically addressed
in FALCON-15. 

> Post processing should propagate user information in messages for offline processing
> ------------------------------------------------------------------------------------
>
>                 Key: FALCON-220
>                 URL: https://issues.apache.org/jira/browse/FALCON-220
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: messaging
>    Affects Versions: 0.4, 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: security
>         Attachments: FALCON-220.patch
>
>
> Late data handling, retries need to execute the jobs as the user who submitted it requiring
propagation of user information.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message