falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shwetha...@inmobi.com
Subject Re: Review Request 17525: FALCON-264 Update with effectiveTime in CLI
Date Fri, 31 Jan 2014 07:03:21 GMT


> On Jan. 30, 2014, 6:05 a.m., shaik idris wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 362
> > <https://reviews.apache.org/r/17525/diff/1/?file=454208#file454208line362>
> >
> >     This validation should be at API level, if CLI is bypassed.

Yes, I noticed it. But all the other validations are at CLI, hence I added it here. Will move
this to client


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17525/#review33203
-----------------------------------------------------------


On Jan. 30, 2014, 5:48 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17525/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:48 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-264
>     https://issues.apache.org/jira/browse/FALCON-264
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Update with effective time in CLI
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 6cb388e 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a7207f 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java
025e1b7 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 7c3a425

>   pom.xml 9252d80 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 7333110 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java
bbb1120 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java 86e0431 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 1ceaabf

> 
> Diff: https://reviews.apache.org/r/17525/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message