falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 17526: FALCON-221 Logmover is not copying all action level logs
Date Thu, 30 Jan 2014 08:12:50 GMT


> On Jan. 30, 2014, 8:08 a.m., Amareshwari Sriramadasu wrote:
> > oozie/src/main/java/org/apache/falcon/logging/LogMover.java, line 213
> > <https://reviews.apache.org/r/17526/diff/1/?file=454219#file454219line213>
> >
> >     should we create the TaskLogURLRetriever once and use it across all getTTlogURL
calls?

It is typically called only once. 


> On Jan. 30, 2014, 8:08 a.m., Amareshwari Sriramadasu wrote:
> > oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java,
line 81
> > <https://reviews.apache.org/r/17526/diff/1/?file=454221#file454221line81>
> >
> >     do you want to use JobHistory.JobInfo.decodeJobHistoryFileName ?

Yes. Makes sense. Will upload revised patch with this change


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33205
-----------------------------------------------------------


On Jan. 30, 2014, 5:49 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:49 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-221
>     https://issues.apache.org/jira/browse/FALCON-221
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Logmover is not copying all action level logs
> 
> 
> Diffs
> -----
> 
>   oozie/pom.xml a6514e4 
>   oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d 
>   oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION

>   oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17526/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message