falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu" <amareshw...@apache.org>
Subject Re: Review Request 17526: FALCON-221 Logmover is not copying all action level logs
Date Thu, 30 Jan 2014 08:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17526/#review33205
-----------------------------------------------------------


getFromHistory() and getHistoryFile() code looks fine. Couple of minor comments posted.


oozie/src/main/java/org/apache/falcon/logging/LogMover.java
<https://reviews.apache.org/r/17526/#comment62568>

    should we create the TaskLogURLRetriever once and use it across all getTTlogURL calls?



oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java
<https://reviews.apache.org/r/17526/#comment62567>

    do you want to use JobHistory.JobInfo.decodeJobHistoryFileName ?


- Amareshwari Sriramadasu


On Jan. 30, 2014, 5:49 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17526/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 5:49 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-221
>     https://issues.apache.org/jira/browse/FALCON-221
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Logmover is not copying all action level logs
> 
> 
> Diffs
> -----
> 
>   oozie/pom.xml a6514e4 
>   oozie/src/main/java/org/apache/falcon/logging/DefaultTaskLogRetriever.java PRE-CREATION

>   oozie/src/main/java/org/apache/falcon/logging/LogMover.java afdc36d 
>   oozie/src/main/java/org/apache/falcon/logging/TaskLogURLRetriever.java PRE-CREATION

>   oozie/src/versioned-src/v2/java/org/apache/falcon/logging/v1/TaskLogRetrieverV1.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17526/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message