falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Seetharam Venkatesh" <venkat...@innerzeal.com>
Subject Re: Review Request 17148: Improve build speeds in falcon
Date Wed, 22 Jan 2014 00:53:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17148/#review32448
-----------------------------------------------------------

Ship it!



acquisition/pom.xml
<https://reviews.apache.org/r/17148/#comment61292>

    Why is this necessary?



client/src/main/java/org/apache/falcon/cli/FalconCLI.java
<https://reviews.apache.org/r/17148/#comment61293>

    Isn't this useful for all calls? User wont see an exception if version call fails, no?



common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java
<https://reviews.apache.org/r/17148/#comment61294>

    This is very nice, I used to despise this. :-)



hadoop-dependencies/pom.xml
<https://reviews.apache.org/r/17148/#comment61296>

    What does this do?



hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java
<https://reviews.apache.org/r/17148/#comment61301>

    Where is the class org.apache.falcon.JobTrackerService in the patch? Its missing.



hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java
<https://reviews.apache.org/r/17148/#comment61299>

    Since you have done this much, why not extend it to hive metastore and start a local metastore
instead of a remote one?
    All you need to do is to set hive.metastore.local to true and you are good to go. Else
open a jira.



hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java
<https://reviews.apache.org/r/17148/#comment61300>

    Is there a local option for Broker. Question for Jean. :-)



hadoop-webapp/src/main/resources/core-site.xml
<https://reviews.apache.org/r/17148/#comment61302>

    Where is this class org.apache.falcon.hadoop.JailedFileSystem in the patch? Its missing.



pom.xml
<https://reviews.apache.org/r/17148/#comment61291>

    You can remove this, no?


- Seetharam Venkatesh


On Jan. 21, 2014, 5:14 p.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17148/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 5:14 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-123
>     https://issues.apache.org/jira/browse/FALCON-123
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Currently default build includes javadocs generation, sources packaging, checkstyle verification
& findbugs verification besides whole lots of unit tests and integration tests. It would
be good to move some of these to test-patch (verified by hudson) and during nightly builds.
> 
> 
> Diffs
> -----
> 
>   acquisition/pom.xml e2017dd 
>   archival/pom.xml c43e645 
>   build-tools/pom.xml 7a020d3 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java 01d2ced 
>   common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java 10a9cc0 
>   common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java 6917472 
>   feed/src/test/java/org/apache/falcon/converter/OozieFeedMapperTest.java 128784e 
>   hadoop-dependencies/pom.xml 225b9d9 
>   hadoop-webapp/pom.xml 7640883 
>   hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java c2bb6f7

>   hadoop-webapp/src/main/resources/core-site.xml 484e904 
>   hadoop-webapp/src/main/resources/hive-site.xml 49cda78 
>   hadoop-webapp/src/main/resources/yarn-site.xml 587f1c5 
>   messaging/pom.xml a59c1e3 
>   messaging/src/test/java/org/apache/falcon/messaging/FalconTopicProducerTest.java 27bea68

>   messaging/src/test/java/org/apache/falcon/messaging/FeedProducerTest.java a1609af 
>   messaging/src/test/java/org/apache/falcon/messaging/ProcessProducerTest.java 078b9c2

>   metrics/pom.xml 1ed4f6b 
>   oozie-el-extensions/pom.xml 4c76c89 
>   pom.xml 36c5f7a 
>   process/src/test/java/org/apache/falcon/converter/OozieProcessMapperTest.java 794e585

>   test-util/pom.xml 6bd4129 
>   test-util/src/main/java/org/apache/falcon/cluster/util/EmbeddedCluster.java c443e05

>   webapp/pom.xml 0c2d844 
>   webapp/src/conf/oozie/conf/action-conf/hive.xml e5aef7d 
>   webapp/src/conf/oozie/conf/hadoop-conf/core-site.xml 35078c7 
>   webapp/src/conf/oozie/conf/oozie-site.xml 48408ba 
>   webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java c4d6671 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 4730728 
>   webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java 9b672f4

>   webapp/src/test/java/org/apache/falcon/process/PigProcessIT.java 58ae4ba 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java aa059bd

>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java ac15391

>   webapp/src/test/java/org/apache/falcon/resource/TestContext.java 3fcd5dc 
>   webapp/src/test/resources/cluster-template.xml 32eb643 
> 
> Diff: https://reviews.apache.org/r/17148/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message