falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-185) Timestamp handled as int
Date Wed, 13 Nov 2013 06:30:19 GMT

    [ https://issues.apache.org/jira/browse/FALCON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820994#comment-13820994
] 

Venkatesh Seetharam commented on FALCON-185:
--------------------------------------------

There is a checkstyle violation: 
/incubator-falcon/rerun/src/test/java/org/apache/falcon/rerun/handler/TestLateRerunHandler.java:31:
Missing a Javadoc comment.

> Timestamp handled as int
> ------------------------
>
>                 Key: FALCON-185
>                 URL: https://issues.apache.org/jira/browse/FALCON-185
>             Project: Falcon
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>             Fix For: 0.4
>
>         Attachments: FALCON-185.patch
>
>
> In LateRerunHandler,
>     public static Date addTime(Date date, int milliSecondsToAdd) {
>         return new Date(date.getTime() + milliSecondsToAdd);
>     }
>             endTime = addTime(endTime, (int) feedCutOffPeriod);
> Changing msecs as int makes the timestamp -ve if the value is big. Thanks [~samarthg]
for pointing this issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message