falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-37) Falcon - Dashboard Feature
Date Thu, 17 Oct 2013 17:19:42 GMT

    [ https://issues.apache.org/jira/browse/FALCON-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798115#comment-13798115
] 

Srikanth Sundarrajan commented on FALCON-37:
--------------------------------------------

Should this simply be toString() 
{code}
+    public String getGraphAsString(){
{code}

We seem to be returning AbstractMap::toString(). This may not produce consistently well formed
json, besides the structure is not easily consumable.
{code}
+    public  String getEntityGraph() {
+
+        try {
+            return EntityGraph.get().getGraphAsString();
+        } catch (Exception e) {
+            LOG.error("Problem getting EntityGraph");
+            throw FalconWebException.newException(e, Response.Status.BAD_REQUEST);
+        }
+    }
{code}

Should we look to have a PathParam for the entity type & name which can be null. If provided,
we can provide elements around this entity (depth =1).
{code}
+    @Path("get/graph")
+    @Produces(MediaType.APPLICATION_JSON)
+    @Monitored(event = "graph")
+    @Override
+    public String getEntityGraph() {
+        return super.getEntityGraph();
+    }
+
{code}

> Falcon - Dashboard Feature
> --------------------------
>
>                 Key: FALCON-37
>                 URL: https://issues.apache.org/jira/browse/FALCON-37
>             Project: Falcon
>          Issue Type: New Feature
>          Components: general
>    Affects Versions: 0.4
>            Reporter: Srikanth Sundarrajan
>            Assignee: Srikanth Vittal
>              Labels: patch
>         Attachments: FALCON-37-r1.patch, Falcon – Dashboard.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message