Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@falcon.incubator.apache.org
Date: Fri, 13 Sep 2013 19:11:51 +0000 (UTC)
From: "Srikanth Sundarrajan (JIRA)" <jira@apache.org>
To: dev@falcon.incubator.apache.org
Message-ID: <JIRA.12660007.1374832970544.131201.1379099511643@arcas>
In-Reply-To: <JIRA.12660007.1374832970544@arcas>
References: <JIRA.12660007.1374832970544@arcas>
Subject: [jira] [Commented] (FALCON-63) Ability to ingest hadoop libs to
 falcon release package
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FALCON-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766829#comment-13766829 ] 

Srikanth Sundarrajan commented on FALCON-63:
--------------------------------------------

When using set -e, it is important to consider cases where there is a possibility of a non-zero exit code from a command is not considered a failure.
{code}
+HADOOPDIR=`which hadoop`

should actually be 

+true || HADOOPDIR=`which hadoop`
{code}

Accidentally reopened the JIRA, it might be better to close this in a separate one. 

The reason why set -e is perhaps done is to avoid checking return status of each command which could potentially be an abort condition. If there are fewer such statements, we should avoid using set -e. In this particular case for service-start.sh, set -e seems unnecessary.
                
> Ability to ingest hadoop libs to falcon release package
> -------------------------------------------------------
>
>                 Key: FALCON-63
>                 URL: https://issues.apache.org/jira/browse/FALCON-63
>             Project: Falcon
>          Issue Type: Sub-task
>            Reporter: Shwetha G S
>            Assignee: Suhas Vasu
>             Fix For: 0.4
>
>         Attachments: FALCON-63.patch, FALCON-63-v2.patch, FALCON-63-v3.patch, FALCON-63-v4.patch, FALCON-63-v5.patch, FALCON-63-v6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira