falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-63) Ability to ingest hadoop libs to falcon release package
Date Fri, 13 Sep 2013 06:14:53 GMT

    [ https://issues.apache.org/jira/browse/FALCON-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766270#comment-13766270
] 

Suresh Srinivas commented on FALCON-63:
---------------------------------------

This patch introduces the following line in service-start.sh:
{code}
+HADOOPDIR=`which hadoop`
+if [ "$HADOOPDIR" != "" ]; then
+  echo "Hadoop is installed, adding hadoop classpath to falcon classpath"
+  FALCONCPPATH="${FALCONCPPATH}:`hadoop classpath`"
{code}

The problem is the script has {{set -e}}. That means in setups where {{which hadoop}} fails,
the script exists and does not proceed to the if statement.

Why are falcon scripts using {{set -e}}? If commands in the scripts can fail, we should remove
{{set -e}}. If there is not specific reason for this, I can open a jira to remove it.
                
> Ability to ingest hadoop libs to falcon release package
> -------------------------------------------------------
>
>                 Key: FALCON-63
>                 URL: https://issues.apache.org/jira/browse/FALCON-63
>             Project: Falcon
>          Issue Type: Sub-task
>            Reporter: Shwetha G S
>            Assignee: Suhas Vasu
>             Fix For: 0.4
>
>         Attachments: FALCON-63.patch, FALCON-63-v2.patch, FALCON-63-v3.patch, FALCON-63-v4.patch,
FALCON-63-v5.patch, FALCON-63-v6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message