falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-87) Hive table integration with feed entity
Date Sat, 31 Aug 2013 20:25:51 GMT

    [ https://issues.apache.org/jira/browse/FALCON-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755588#comment-13755588
] 

Venkatesh Seetharam commented on FALCON-87:
-------------------------------------------

Srikanth, thanks for the review. Are you looking at the latest patch? I remember correcting
the OozieProcessMapper and the syncdataset URI template. 

bq. Current user who is creating the feed is being passed as the user.name. I am assuming
that this user has enough permission to access the ddl. Please confirm.
Yes. This is used when a user submits a feed to falcon with a table as the storage. I verify
if the table actually exists and is accessible by the user submitting this feed.

bq. Since the catalog service should be created by the factory only if the scheme is catalog,
this should never occur, if we check, it might be better throw an illegal state or assertion
error. Does it simplify this function if we create a regex pattern and validate the uri against
that (and possibly enforce it in xsd as well)?
This is NOT created in the service factory. This is the table URI in the feed. XSD might be
a better place but its simple enough now IMO.

bq. Should this be equals() instead?
Yes thats the intent but equals need hashcode and such which I did not bother to write.

bq. junit - reintroduced.
Oops! Good catch. My bad.

bq. OozieProcessMapper.java::
You must be looking into old patch. The new patch does take care of this.

{code}
        String locPath = FeedHelper.createStorage(cluster, feed).getUriTemplate(locationType);
        syncdataset.setUriTemplate(locPath);
{code}

bq. Besides, few commented out stale code exists.
Where are they? org.apache.falcon.listener.HadoopStartupListener already had 'em.

                
> Hive table integration with feed entity
> ---------------------------------------
>
>                 Key: FALCON-87
>                 URL: https://issues.apache.org/jira/browse/FALCON-87
>             Project: Falcon
>          Issue Type: Sub-task
>    Affects Versions: 0.4
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>         Attachments: FALCON-87.patch, FALCON-87-review.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message