falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Venkatesh Seetharam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-72) Feeds with invalid oozie URI in cluster cannot be deleted
Date Fri, 09 Aug 2013 06:14:49 GMT

    [ https://issues.apache.org/jira/browse/FALCON-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734439#comment-13734439
] 

Venkatesh Seetharam commented on FALCON-72:
-------------------------------------------

Thanks [~sriksun] for the comments.

bq. It would be better to depend on javax.jms in falcon-common module as opposed to active-mq.

Agreed, will change.

bq. Checkstyle errors
Sorry about that. I moved custom code to data provider and did not verify. 

Thanks [~shwethags] for the comments.

bq. 1. Move validateFileSystemScheme(cluster, ClusterHelper.getStorageUrl(cluster), Interfacetype.WRITE)
in validate() to validateWriteInterface()
Fail early, fail often. the scheme is validated early and everything else is late. This is
how it was.

bq. 2. For validateWorkflowInterface(), why not call some API through OozieClient
Oozie is not a dependency and its only making a call using http. Will reuse this for Hive
as well.

bq. 3. validate call is removed in ClusterEntityParserTest. Is that intentional?
Yes, as services are not up and running. Hence moved validation into integration-tests, created
a new one.


                
> Feeds with invalid oozie URI in cluster cannot be deleted
> ---------------------------------------------------------
>
>                 Key: FALCON-72
>                 URL: https://issues.apache.org/jira/browse/FALCON-72
>             Project: Falcon
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>         Attachments: FALCON-72.patch
>
>
> User submits a cluster dsl with a bad oozie uri. He then submits a feed with this cluster.
User will never be able to remove the feed from Falcon. 
> I'd suggest we add validations for all the interfaces:
> * Execute - create a JobClient object
> * Workflow - This is initialized quite late
> * Messaging - not sure if we need to validate this? Will Falcon work without this?
> * Read - Why not validate this as well?
> Thanks Grant Liu for bringing this to my attention.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message