falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FALCON-72) Feeds with invalid oozie URI in cluster cannot be deleted
Date Fri, 09 Aug 2013 05:21:47 GMT

    [ https://issues.apache.org/jira/browse/FALCON-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734407#comment-13734407
] 

Srikanth Sundarrajan commented on FALCON-72:
--------------------------------------------

Few issues with the patch:

It would be better to depend on javax.jms in falcon-common module as opposed to active-mq.
If any user wants to replace active-mq with any other messaging solution of their choice,
then it would require a lot more changes / customization. Would be best if specific reference
to an implementation is restricted to the messaging module. 

Test failures:
{code}
testClusterEntityWithInvalidInterfaces(org.apache.falcon.resource.ClusterEntityValidationIT)
 Time elapsed: 0.091 sec  <<< FAILURE!
org.testng.TestException:
Method org.apache.falcon.resource.ClusterEntityValidationIT.testClusterEntityWithInvalidInterfaces(org.apache.falcon.entity.v0.cluster.Interfacetype,
java.lang.String) should have t
hrown an exception of class org.apache.falcon.entity.parser.ValidationException

testClusterEntityWithInvalidInterfaces(org.apache.falcon.resource.ClusterEntityValidationIT)
 Time elapsed: 0.011 sec  <<< FAILURE!
org.testng.TestException:
Method org.apache.falcon.resource.ClusterEntityValidationIT.testClusterEntityWithInvalidInterfaces(org.apache.falcon.entity.v0.cluster.Interfacetype,
java.lang.String) should have t
hrown an exception of class org.apache.falcon.entity.parser.ValidationException

testClusterEntityWithInvalidInterfaces(org.apache.falcon.resource.ClusterEntityValidationIT)
 Time elapsed: 0.026 sec  <<< FAILURE!
org.testng.TestException:
Method org.apache.falcon.resource.ClusterEntityValidationIT.testClusterEntityWithInvalidInterfaces(org.apache.falcon.entity.v0.cluster.Interfacetype,
java.lang.String) should have t
hrown an exception of class org.apache.falcon.entity.parser.ValidationException

testClusterEntityWithInvalidInterfaces(org.apache.falcon.resource.ClusterEntityValidationIT)
 Time elapsed: 0.005 sec  <<< FAILURE!
org.testng.TestException:
Method org.apache.falcon.resource.ClusterEntityValidationIT.testClusterEntityWithInvalidInterfaces(org.apache.falcon.entity.v0.cluster.Interfacetype,
java.lang.String) should have thrown an exception of class org.apache.falcon.entity.parser.ValidationException
{code}

Checkstyle errors:
{code}
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:94:
Comment matches to-do format 'TODO:'.
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:96:
array initialization lcurly at indentation level 16 not at correct indentation, 12
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:97:
array initialization lcurly at indentation level 16 not at correct indentation, 12
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:98:
array initialization lcurly at indentation level 16 not at correct indentation, 12
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:99:
array initialization lcurly at indentation level 16 not at correct indentation, 12
/projects/incubator-falcon/webapp/src/test/java/org/apache/falcon/resource/ClusterEntityValidationIT.java:100:
Array should contain trailing comma.
Audit done.

[INFO] There are 6 checkstyle errors.
{code}
                
> Feeds with invalid oozie URI in cluster cannot be deleted
> ---------------------------------------------------------
>
>                 Key: FALCON-72
>                 URL: https://issues.apache.org/jira/browse/FALCON-72
>             Project: Falcon
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 0.3
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>         Attachments: FALCON-72.patch
>
>
> User submits a cluster dsl with a bad oozie uri. He then submits a feed with this cluster.
User will never be able to remove the feed from Falcon. 
> I'd suggest we add validations for all the interfaces:
> * Execute - create a JobClient object
> * Workflow - This is initialized quite late
> * Messaging - not sure if we need to validate this? Will Falcon work without this?
> * Read - Why not validate this as well?
> Thanks Grant Liu for bringing this to my attention.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message