Return-Path: X-Original-To: apmail-falcon-dev-archive@minotaur.apache.org Delivered-To: apmail-falcon-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3942A10459 for ; Sun, 28 Jul 2013 06:15:31 +0000 (UTC) Received: (qmail 33699 invoked by uid 500); 28 Jul 2013 06:15:29 -0000 Delivered-To: apmail-falcon-dev-archive@falcon.apache.org Received: (qmail 33682 invoked by uid 500); 28 Jul 2013 06:15:28 -0000 Mailing-List: contact dev-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list dev@falcon.incubator.apache.org Received: (qmail 33674 invoked by uid 99); 28 Jul 2013 06:15:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2013 06:15:26 +0000 X-ASF-Spam-Status: No, hits=-1999.3 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 28 Jul 2013 06:15:23 +0000 Received: (qmail 33631 invoked by uid 99); 28 Jul 2013 06:15:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Jul 2013 06:15:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D471C1D0DDD; Sun, 28 Jul 2013 06:14:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7069074834216776035==" MIME-Version: 1.0 Subject: Re: Review Request 12987: Properties load should fall back to classpath if not present in config.location From: "Seetharam Venkatesh" To: "Seetharam Venkatesh" , "Falcon" , "Srikanth Sundarrajan" Date: Sun, 28 Jul 2013 06:14:59 -0000 Message-ID: <20130728061459.537.99715@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Seetharam Venkatesh" X-ReviewGroup: Falcon X-ReviewRequest-URL: https://reviews.apache.org/r/12987/ X-Sender: "Seetharam Venkatesh" References: <20130728060417.32008.98374@reviews.apache.org> In-Reply-To: <20130728060417.32008.98374@reviews.apache.org> Reply-To: "Seetharam Venkatesh" X-Virus-Checked: Checked by ClamAV on apache.org --===============7069074834216776035== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On July 28, 2013, 6:04 a.m., Seetharam Venkatesh wrote: > > Ship It! You need to add me as a reviewer so I can cancel my comments? Sorry, I updated the review prematurely. I do see one issue. Somehow I see each of the properties being initialized twice apart from logging it twice in each. I'm attaching the application.log for your convenience in the jira. - Seetharam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12987/#review24055 ----------------------------------------------------------- On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12987/ > ----------------------------------------------------------- > > (Updated July 27, 2013, 12:02 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-65 > https://issues.apache.org/jira/browse/FALCON-65 > > > Repository: falcon-git > > > Description > ------- > > Properties load should fall back to classpath if not present in config.location > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729 > common/src/main/resources/startup.properties 4ff00d7 > common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION > common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06 > common/src/test/resources/classpath.properties PRE-CREATION > pom.xml ca16762 > src/bin/falcon-start 9a68220 > webapp/pom.xml 6743527 > > Diff: https://reviews.apache.org/r/12987/diff/ > > > Testing > ------- > > > Thanks, > > Srikanth Sundarrajan > > --===============7069074834216776035==--