falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Seetharam Venkatesh" <venkat...@innerzeal.com>
Subject Re: Review Request 12987: Properties load should fall back to classpath if not present in config.location
Date Sun, 28 Jul 2013 06:14:59 GMT


> On July 28, 2013, 6:04 a.m., Seetharam Venkatesh wrote:
> > Ship It!

You need to add me as a reviewer so I can cancel my comments?

Sorry, I updated the review prematurely. I do see one issue. Somehow I see each of the properties
being initialized twice apart from logging it twice in each. I'm attaching the application.log
for your convenience in the jira.


- Seetharam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24055
-----------------------------------------------------------


On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 12:02 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-65
>     https://issues.apache.org/jira/browse/FALCON-65
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Properties load should fall back to classpath if not present in config.location
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729 
>   common/src/main/resources/startup.properties 4ff00d7 
>   common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION

>   common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06 
>   common/src/test/resources/classpath.properties PRE-CREATION 
>   pom.xml ca16762 
>   src/bin/falcon-start 9a68220 
>   webapp/pom.xml 6743527 
> 
> Diff: https://reviews.apache.org/r/12987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message