falcon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srikanth Sundarrajan" <srik...@hotmail.com>
Subject Re: Review Request 12987: Properties load should fall back to classpath if not present in config.location
Date Sun, 28 Jul 2013 02:40:52 GMT


> On July 27, 2013, 6 p.m., Seetharam Venkatesh wrote:
> > All the changes look good. You had to create dependencies to work around the pom.version.
I do not understand the changes to filtering in super pom. You exclude in one and include
in another. Can you please clarify what is going on?

We exclude startup.properties, runtime.properties & log4j.xml from filtering by adding
them in the exclude section. But excluding them will prevent them from being copied entirely.
So another section is added to include them, but now without performing the maven resource
filtering. Does that help ?


- Srikanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12987/#review24035
-----------------------------------------------------------


On July 27, 2013, 12:02 p.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12987/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 12:02 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-65
>     https://issues.apache.org/jira/browse/FALCON-65
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Properties load should fall back to classpath if not present in config.location
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/util/ApplicationProperties.java 3746729 
>   common/src/main/resources/startup.properties 4ff00d7 
>   common/src/test/java/org/apache/falcon/util/ApplicationPropertiesTest.java PRE-CREATION

>   common/src/test/java/org/apache/falcon/util/StartupPropertiesTest.java 6b2ec06 
>   common/src/test/resources/classpath.properties PRE-CREATION 
>   pom.xml ca16762 
>   src/bin/falcon-start 9a68220 
>   webapp/pom.xml 6743527 
> 
> Diff: https://reviews.apache.org/r/12987/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message