falcon-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pall...@apache.org
Subject falcon git commit: FALCON-2121 If a feed does not exist on a cluster, process submission throws NPE
Date Wed, 31 Aug 2016 10:35:44 GMT
Repository: falcon
Updated Branches:
  refs/heads/master edebc48ac -> d2c8adfad


FALCON-2121 If a feed does not exist on a cluster, process submission throws NPE

After the change:
`bin/falcon entity -submit -type process -file examples/entity/filesystem/pig-process.xml
ERROR: Bad Request;default/Feed in does not exist on cluster local2`

Author: Pallavi Rao <pallavi.rao@inmobi.com>

Reviewers: @sandeepSamudrala

Closes #270 from pallavi-rao/2121 and squashes the following commits:

ed3a8f4 [Pallavi Rao] Addressed review comment
0884518 [Pallavi Rao] FALCON-2121 Removing static import
60d1e00 [Pallavi Rao] FALCON-2121 If a feed does not exist on a cluster, process submission
fails with NPE


Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/d2c8adfa
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/d2c8adfa
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/d2c8adfa

Branch: refs/heads/master
Commit: d2c8adfadf0d25a5956194f3e82c85a5677a42fb
Parents: edebc48
Author: Pallavi Rao <pallavi.rao@inmobi.com>
Authored: Wed Aug 31 16:05:24 2016 +0530
Committer: Pallavi Rao <pallavi.rao@inmobi.com>
Committed: Wed Aug 31 16:05:24 2016 +0530

----------------------------------------------------------------------
 .../org/apache/falcon/entity/parser/CrossEntityValidations.java    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/falcon/blob/d2c8adfa/common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java
b/common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java
index 18ae754..d4b79fd 100644
--- a/common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java
+++ b/common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java
@@ -44,6 +44,7 @@ public final class CrossEntityValidations {
         try {
             for (Cluster cluster : process.getClusters().getClusters()) {
                 String clusterName = cluster.getName();
+                validateFeedDefinedForCluster(feed, clusterName);
                 org.apache.falcon.entity.v0.feed.Validity feedValidity = FeedHelper.getCluster(feed,
                         clusterName).getValidity();
 
@@ -110,6 +111,7 @@ public final class CrossEntityValidations {
         try {
             for (Cluster cluster : process.getClusters().getClusters()) {
                 String clusterName = cluster.getName();
+                validateFeedDefinedForCluster(feed, clusterName);
                 org.apache.falcon.entity.v0.feed.Validity feedValidity = FeedHelper.getCluster(feed,
                         clusterName).getValidity();
                 Date feedStart = feedValidity.getStart();


Mime
View raw message