falcon-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b...@apache.org
Subject falcon git commit: FALCON-2018 WorkflowJobNotification sends incorrect message for kille…
Date Wed, 08 Jun 2016 18:10:00 GMT
Repository: falcon
Updated Branches:
  refs/heads/master ee644dd2a -> a4e18a4d4


FALCON-2018 WorkflowJobNotification sends incorrect message for kille…

…d instances

Author: Praveen Adlakha <adlakha.praveen@gmail.com>

Reviewers: "Balu Vellanki <balu@apache.org>"

Closes #179 from PraveenAdlakha/2018


Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/a4e18a4d
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/a4e18a4d
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/a4e18a4d

Branch: refs/heads/master
Commit: a4e18a4d428569c37e65e281c3c36bf3ed737eed
Parents: ee644dd
Author: Praveen Adlakha <adlakha.praveen@gmail.com>
Authored: Wed Jun 8 11:10:15 2016 -0700
Committer: bvellanki <bvellanki@hortonworks.com>
Committed: Wed Jun 8 11:10:15 2016 -0700

----------------------------------------------------------------------
 .../apache/falcon/workflow/WorkflowJobEndNotificationService.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/falcon/blob/a4e18a4d/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
b/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
index b692258..fbd1e3f 100644
--- a/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
+++ b/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
@@ -299,7 +299,7 @@ public class WorkflowJobEndNotificationService implements FalconService
{
         }
         Long duration = (endTime.getTime() - startTime.getTime()) * 1000000;
 
-        if (context.hasWorkflowFailed()) {
+        if (!context.hasWorkflowSucceeded()) {
             GenericAlert.instrumentFailedInstance(clusterName, entityType,
                     entityName, nominalTime, workflowId, workflowUser, runId, operation,
                     SchemaHelper.formatDateUTC(startTime), "", "", duration);


Mime
View raw message