Return-Path: X-Original-To: apmail-falcon-commits-archive@minotaur.apache.org Delivered-To: apmail-falcon-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CABD910D3F for ; Wed, 15 Oct 2014 16:48:39 +0000 (UTC) Received: (qmail 52002 invoked by uid 500); 15 Oct 2014 16:48:39 -0000 Delivered-To: apmail-falcon-commits-archive@falcon.apache.org Received: (qmail 51964 invoked by uid 500); 15 Oct 2014 16:48:39 -0000 Mailing-List: contact commits-help@falcon.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.incubator.apache.org Delivered-To: mailing list commits@falcon.incubator.apache.org Received: (qmail 51955 invoked by uid 99); 15 Oct 2014 16:48:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 16:48:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Oct 2014 16:48:15 +0000 Received: (qmail 51602 invoked by uid 99); 15 Oct 2014 16:48:13 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 16:48:13 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id E381192F9AB; Wed, 15 Oct 2014 16:48:12 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: raghav@apache.org To: commits@falcon.incubator.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: git commit: FALCON-809 Add message from response if assertSucceeded fails. Contributed by Ruslan Ostafiychuk Date: Wed, 15 Oct 2014 16:48:12 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Repository: incubator-falcon Updated Branches: refs/heads/master c6cee1137 -> 688fc4557 FALCON-809 Add message from response if assertSucceeded fails. Contributed by Ruslan Ostafiychuk Project: http://git-wip-us.apache.org/repos/asf/incubator-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-falcon/commit/688fc455 Tree: http://git-wip-us.apache.org/repos/asf/incubator-falcon/tree/688fc455 Diff: http://git-wip-us.apache.org/repos/asf/incubator-falcon/diff/688fc455 Branch: refs/heads/master Commit: 688fc4557637bb1a12b0f1924a9e7457d94c6968 Parents: c6cee11 Author: Raghav Kumar Gautam Authored: Wed Oct 15 09:48:03 2014 -0700 Committer: Raghav Kumar Gautam Committed: Wed Oct 15 09:48:03 2014 -0700 ---------------------------------------------------------------------- falcon-regression/CHANGES.txt | 2 ++ .../apache/falcon/regression/core/util/AssertUtil.java | 12 ++++++------ 2 files changed, 8 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/688fc455/falcon-regression/CHANGES.txt ---------------------------------------------------------------------- diff --git a/falcon-regression/CHANGES.txt b/falcon-regression/CHANGES.txt index efd5b39..96d3d37 100644 --- a/falcon-regression/CHANGES.txt +++ b/falcon-regression/CHANGES.txt @@ -14,6 +14,8 @@ Trunk (Unreleased) via Samarth Gupta) IMPROVEMENTS + FALCON-809 Add message from response if assertSucceeded fails (Ruslan Ostafiychuk) + FALCON-802 Authorization test disabled (Paul Isaychuk) FALCON-706 Parse json with instances to InstancesResult using joda's DateTime (Ruslan http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/688fc455/falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java ---------------------------------------------------------------------- diff --git a/falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java b/falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java index c0c5755..569d1f3 100644 --- a/falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java +++ b/falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java @@ -158,11 +158,11 @@ public final class AssertUtil { */ public static void assertSucceeded(ServiceResponse response) throws JAXBException { final APIResult apiResult = Util.parseResponse(response); - Assert.assertEquals(apiResult.getStatus(), - APIResult.Status.SUCCEEDED, "Status should be SUCCEEDED"); - Assert.assertEquals(apiResult.getStatusCode(), 200, - "Status code should be 200"); Assert.assertNotNull(apiResult.getMessage(), "Status message is null"); + Assert.assertEquals(apiResult.getStatus(), APIResult.Status.SUCCEEDED, + "Status should be SUCCEEDED. Message: " + apiResult.getMessage()); + Assert.assertEquals(apiResult.getStatusCode(), 200, + "Status code should be 200. Message: " + apiResult.getMessage()); } /** @@ -189,9 +189,9 @@ public final class AssertUtil { * @param response ProcessInstancesResult */ public static void assertSucceeded(InstancesResult response) { - Assert.assertNotNull(response.getMessage()); + Assert.assertNotNull(response.getMessage(), "Status message is null"); Assert.assertEquals(response.getStatus(), APIResult.Status.SUCCEEDED, - "Status should be SUCCEEDED"); + "Status should be SUCCEEDED. Message: " + response.getMessage()); } /**