excalibur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leo Simons <m...@leosimons.com>
Subject Re: svn commit: r492447
Date Tue, 23 Jan 2007 11:39:44 GMT
On Jan 4, 2007, at 9:31 AM, cziegeler@apache.org wrote:
>  import java.util.List;
>
> -import org.apache.avalon.framework.component.Component;
>  import org.apache.avalon.framework.thread.ThreadSafe;
>
>  import org.jaxen.NamespaceContext;
> @@ -43,7 +42,7 @@
>   */
>  public final class JaxenProcessorImpl
>          extends AbstractProcessorImpl
> -        implements XPathProcessor, Component, ThreadSafe
> +        implements XPathProcessor, ThreadSafe
>  {

Ah, it seems like you took out the "implements Component" nearly  
everywhere.

This will break all applications using excalibur components with a  
container that depends on "Component" being implemented. Removing an  
implements interface can also break stuff like serialization...

I think that unless there's a really good reason for it, you should  
roll these back :-/

- LSD


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Mime
View raw message