excalibur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylv...@apache.org>
Subject Re: Optimizing SourceResolver.release()
Date Mon, 01 Aug 2005 13:29:29 GMT
Carsten Ziegeler wrote:

>Sylvain Wallez schrieb:
>
>  
>
>>Well, it's difficult to do something better than a few hashmap puts and 
>>gets, and possibly crawl up the service manager hierarchy. All this to 
>>end up calling an empty method...
>>
>>    
>>
>What about caching the source factories in the source resolver
>implementation?
>During runtime a service manager and selector do never change, so once
>the source resolver has looked up a factory, it can put it into a map.
>On releasing a source, there is then just one single lookup into a map
>that might contain 8 or 10 different source factories.
>So this way we have only one single lookup into a small map while we
>have an instanceof test with your solution. Actually I would like to go
>the caching way as this just improves the performance without adding
>interfaces that are just there because of possible performance issues.
>  
>

Hmm... I wouldn't go that way, as OSGi-based Cocoon blocks may allow to 
hot-deploy new blocks providing new SourceFactories...

>As Leo and Peter have suggested, did you do any performance tests so we
>can see what these changes actually bring?
>  
>

No. I will do some profiling and come back if this brings significant 
improvements. So let's keep it as is for now.

Sylvain

-- 
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Mime
View raw message