excalibur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter royal <pro...@apache.org>
Subject Re: Optimizing SourceResolver.release()
Date Fri, 29 Jul 2005 17:51:38 GMT
On Jul 28, 2005, at 2:01 PM, Sylvain Wallez wrote:
> All other implementations do _nothing_, leading to a lot of useless  
> lookups. Considering how much source-intensive Cocoon is, this may  
> be significant.
>
> To avoid this, I'd like to propose a small change to the  
> SourceResolver.release() contract: if the Source implements  
> Disposable, then it's dispose() method is called, and otherwise the  
> factory is looked up as of today.

Can you run a test with Cocoon under a profiler to see if making that  
optimization provides a measurable difference in real usage?

Just to avoid optimizing where not necessary (since there are  
backwards-compatibility issues to deal with)
-pete

-- 
peter royal


Mime
View raw message