excalibur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: svn commit: r225589 - /excalibur/trunk/components/sourceresolve/src/java/org/apache/excalibur/source/impl/URLSource.java
Date Thu, 28 Jul 2005 15:11:17 GMT
Vadim Gritsenko schrieb:
> cziegeler-1oDqGaOF3Lkdnm+yROfE0A@public.gmane.org wrote:
> 
>>Author: cziegeler
>>Date: Wed Jul 27 12:50:33 2005
>>New Revision: 225589
>>
>>URL: http://svn.apache.org/viewcvs?rev=225589&view=rev
>>Log:
>>This hopefully fixes bug EXLBR-19
>>
>>+                    // check the status code for exists
>>+                    // if the url does not exists we might also get an IOException
here!
>>+                    try 
>>+                    {
>>+                        final int statusCode = ((HttpURLConnection)m_connection).getResponseCode();
>>+                        if ( statusCode == 200 || statusCode == 303 || statusCode
== 304 )
>>+                        {
> 
> 
> Are you sure you meant 303 [1]? Then you should include 301 and 307 as well.
> 
> Also, codes 500, 502, 503, 504 can happen on existing resource depending on 
> server(s)/network load [2].
> 
> 
Hmm, yeah, you're right - I think we should remove 303 from the list.
Can you do this please? I can't do it in the next days and there will be
new release candidates very soon.

Carsten

-- 
Carsten Ziegeler - Open Source Group, S&N AG
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org


Mime
View raw message