excalibur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leif Mortenson <leifli...@tanukisoftware.com>
Subject Re: Bug in SourceUtil.copy()
Date Tue, 28 Sep 2004 14:47:35 GMT
Vadim Gritsenko wrote:

> Leif Mortenson wrote:
>
>>    I committed a modified patch to SVN as well as went through and 
>> added javadocs to
>> the relevant interfaces making it more obvious that these streams 
>> need to be closed by the
>> calling code.  Could you take a look at the changes and post back if 
>> you see any problems.
>
>
> There are couple of issues... You are loosing original IOException in 
> lines 520, 533, 539:
>   520: modDestination.cancel( out );
>   533: out.close();
>   539: in.close();
> If an IOException has been thrown already, any new IOException which 
> can happen in these lines will cause original IOException to get lost.
>
> Worst case scenario, you are loosing 3 IOExceptions and showing only 
> the very last, fourth one. My gut feeling tells me the very first one 
> usually way more informative than the fourth one.
>
> I guess, ideally, you would preserve original exception in all glory, 
> and add messages from all of the following exceptions if you don't 
> want to ignore them:
>   message += "and on top of that, you've got " + e;

Good point, I was more concerned with being careful that all streams are 
always closed
appropriately.   It now keeps track of the first exception thrown and 
wraps that in a
SourceException.  Thanks for pointing that out.

>> fine on my system.  What version of Maven are you using? and what is 
>> the failure you are
>> seeing?
>>    To build the whole tree, cd into the Excalibur root and run:
>> maven multiproject:install
>
>    As for the build, we are using Maven now rather than Ant.   The 
> Maven build is working
>
> I was soo naive. I was trying simply "maven" from excalibur, and from 
> excalibur/components/sourceresolve directories.
>
> Now, it fails with:
>
>   BUILD FAILED
>   File...... file:/.../.maven/plugins/maven-multiproject-plugin-1.1/
>   Element... maven:reactor
>   Line...... 174
>   Column.... 9
>   The build cannot continue because of the following unsatisfied 
> dependencies:
>
>   mailapi-1.3.1.jar (no download url specified)
>   jms-1.1.jar (no download url specified)

You will need to download those from the Sun site and place them into 
the appropriate
locations in your local maven repository.   Due to licensing issues.  We 
can not provide
them ourselves, or even point directly to jar download locations.  :-/

Cheers,
Leif

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
Apache Excalibur Project -- URL: http://excalibur.apache.org/


Mime
View raw message