Mailing-List: contact etch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: etch-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of sccomer@cisco.com designates
 171.71.176.72 as permitted sender)
Message-ID: <4978A0BE.7050808@cisco.com>
Date: Thu, 22 Jan 2009 10:37:18 -0600
From: scott comer <sccomer@cisco.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: etch-dev@incubator.apache.org
Subject: Re: [vote] include fix in release 1.0.2 (ETCH-28) Examples do not
 build due to outdated ant files.
References: <C59D0707.428C%rebarraz@cisco.com>
In-Reply-To: <C59D0707.428C%rebarraz@cisco.com>
Content-Type: multipart/alternative;
 boundary="------------090209010700040603030608"

--------------090209010700040603030608
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

i applied rene's patch and the build worked for me. so at least he 
hasn't broken anything. i've
not yet checked whether the examples themselves actually build once 
installed.

+1

scott out

Ren� Barraza wrote:
> It seems that the build.xml files in the examples were referencing old
> environment variables that we used to perform the build before releasing
> Etch to the open source community. Attempting to build the examples without
> the proper environment would result in the build failing as Niclas pointed
> out on 1-15-09 in an email entitled "First impressions as 'developer'..."
>
> My fix involves importing ${Etch.basedir}/build-support/etch.includes.xml
> into these build files. I also removed extraneous targets from
> examples/build.xml that are otherwise inherited from etch.includex.xml and
> call the the build_example macro inside the do-build target as per our build
> customs.
>
> I've cleaned and built both the debug and release targets from the sanctity
> of my Mac which does not contain the legacy environment variables that
> allowed this bug to slip through the cracks. All the examples build and run.
>
> PS- I'll be out of town for the next week, if the vote passes and someone
> wishes to apply the patch in my absence, be my guest. :)
>
>
> Regards,
> Ren�
>
>
> On 1/21/09 4:33 PM, "Rene Barraza (JIRA)" <jira@apache.org> wrote:
>
>   
>>      [ 
>> https://issues.apache.org/jira/browse/ETCH-28?page=com.atlassian.jira.plugin.s
>> ystem.issuetabpanels:all-tabpanel ]
>>
>> Rene Barraza updated ETCH-28:
>> -----------------------------
>>
>>     Attachment: etch-examples-patch.txt
>>
>> Patch for fixing the issue. Essentially I included a reference to
>> ${Etch.basedir}/build-support/build.includes.xml to propagate the setting of
>> library variables from build.dependency and leverage the main targets: Clean,
>> Release, Debug, etc.  Please excuse the excess changes from tabs to
>> whitespace.
>>
>>     
>>> Examples do not build due to outdated ant files.
>>> ------------------------------------------------
>>>
>>>                 Key: ETCH-28
>>>                 URL: https://issues.apache.org/jira/browse/ETCH-28
>>>             Project: Etch
>>>          Issue Type: Bug
>>>          Components: examples
>>>    Affects Versions: 1.0.2
>>>         Environment: All
>>>            Reporter: Rene Barraza
>>>            Assignee: Rene Barraza
>>>             Fix For: 1.0.2
>>>
>>>         Attachments: etch-examples-patch.txt
>>>
>>>   Original Estimate: 48h
>>>  Remaining Estimate: 48h
>>>
>>> The build.xml for the various Etch Examples are old and outdated using
>>> customs that were utilized prior to releasing Etch to the open source
>>> community. These scripts need to be refactored to use the existing build
>>> infrastructure.
>>>       
>
>   

--------------090209010700040603030608--