Mailing-List: contact etch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: etch-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of sccomer@cisco.com designates
 171.71.176.70 as permitted sender)
Message-ID: <4975F1BC.4020202@cisco.com>
Date: Tue, 20 Jan 2009 09:46:04 -0600
From: scott comer <sccomer@cisco.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: etch-dev@incubator.apache.org
Subject: Re: [vote] include the fix for etch-25 in release 1.0.2
References: <496E058A.8070004@cisco.com>
In-Reply-To: <496E058A.8070004@cisco.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

+1 to include the fix.

scott comer (sccomer) wrote:
> DefaultDeliveryService ends call with mb.CloseDelivery() and it should 
> end it with mb.CloseRead()
> ------------------------------------------------------------------------------------------------- 
>
>
>                 Key: ETCH-25
>                 URL: https://issues.apache.org/jira/browse/ETCH-25
>             Project: Etch
>          Issue Type: Bug
>          Components: csharp-binding, java-binding
>    Affects Versions: 1.0.1, 1.0.0
>            Reporter: scott comer
>
>
> when done reading the mailbox, the right method to call is 
> CloseRead(). somehow the code actually calls CloseDelivery(), a method 
> used to shutdown the writing side of the mailbox. CloseRead() calls 
> CloseDelivery() first off, but then takes the additional steps of 
> redelivering any messages left in the mailbox.
>
> The distinction is rather fine, and this bug was found by reading the 
> source code. There are certain ways you could exercise this bug, but 
> it would be very rare and not have any real impact. So, it isn't an 
> emergency to fix it, but it is also a relatively benign fix. I've 
> already made the change in my tree and tested it. The patch is attached.
>
> ------------------
>
> there is little risk. all unit tests have passed.
>
> scott out
>
>