Return-Path: X-Original-To: apmail-etch-commits-archive@www.apache.org Delivered-To: apmail-etch-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4735A10694 for ; Tue, 3 Dec 2013 08:09:35 +0000 (UTC) Received: (qmail 3396 invoked by uid 500); 3 Dec 2013 08:09:34 -0000 Delivered-To: apmail-etch-commits-archive@etch.apache.org Received: (qmail 3353 invoked by uid 500); 3 Dec 2013 08:09:31 -0000 Mailing-List: contact commits-help@etch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@etch.apache.org Delivered-To: mailing list commits@etch.apache.org Received: (qmail 3339 invoked by uid 99); 3 Dec 2013 08:09:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2013 08:09:28 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2013 08:09:27 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 74F7D23888E7; Tue, 3 Dec 2013 08:09:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1547309 - /etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm Date: Tue, 03 Dec 2013 08:09:07 -0000 To: commits@etch.apache.org From: veithm@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131203080907.74F7D23888E7@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: veithm Date: Tue Dec 3 08:09:07 2013 New Revision: 1547309 URL: http://svn.apache.org/r1547309 Log: ETCH-275 Fixed SRuntimes Mutex unlock in Code generation The Static SRuntimes Mutex is not unlocked on every Error-Case and resolves to deadlocks. Change-Id: If224cfb273a8627a8e74f1605a863c3b02743d19 Modified: etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm Modified: etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm URL: http://svn.apache.org/viewvc/etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm?rev=1547309&r1=1547308&r2=1547309&view=diff ============================================================================== --- etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm (original) +++ etch/trunk/binding-cpp/compiler/src/main/resources/org/apache/etch/bindings/cpp/compiler/vf_cpp.vm Tue Dec 3 08:09:07 2013 @@ -350,12 +350,14 @@ status_t $vf::InitValueFactory(EtchRunti SRuntimesMutex.lock(); if (SRuntimes.find(runtime->getId()) != SRuntimes.end()) { //runtime is already in list + SRuntimesMutex.unlock(); return ETCH_OK; } status = SRuntimes.push_back(runtime->getId()); runtime->registerListener(&S${i}RuntimeListener); if (status != ETCH_OK) { + SRuntimesMutex.unlock(); return status; }