Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: esme-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of vdichev@gmail.com designates
 209.85.214.47 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=HuoIaaAbFIK52LDQI/eSBMUrctlH45voAO/CJ4tnxXFKpfs+hlsd3P6nrgW7Mvv3me
         3xj8MDgJPaVclcHozxwIaqGU2jVVzPIQIXoLp6P2exLsiFu2LoUku3eSPcLUamVREoPE
         3fAA6xmruSnV7+VJmjTt1d7yzauMjFbbwseFU=
MIME-Version: 1.0
Sender: vdichev@gmail.com
In-Reply-To: <AANLkTin=Eo2BN6sFsBa1GhYadRGDbyst8Aqyd_zwD+Ch@mail.gmail.com>
References: <AANLkTi=bLB0+2C9L=Yx96nrbRE5B-ZNbLc6kzOhjP3o6@mail.gmail.com>
	<AANLkTikkW3RuEZRS9Y5sXA=w2tY2-Two2vQQcALp0gYf@mail.gmail.com>
	<AANLkTimSePTaPpxF9niFt-spD4jdAWHqRYAEprrFjWXi@mail.gmail.com>
	<AANLkTi=w6fE9uObF3=Zy0v5oW4q675Qb_A4pks5HdvQj@mail.gmail.com>
	<AANLkTinaQavwMVe0WDTz0vbsB_5L_pKZfa6gppks9gnT@mail.gmail.com>
	<AANLkTim1JgE_i0Q7z48EmXh8XuYhPs7azFJajEePVTMU@mail.gmail.com>
	<AANLkTi=A2FdA=XyyfiiWv1_Cn5oy93mY+HjMngVkxA8z@mail.gmail.com>
	<AANLkTimGRCrBmFBxv6vi+EayfMB7adYgfPzd9SRz+ghs@mail.gmail.com>
	<AANLkTin=Eo2BN6sFsBa1GhYadRGDbyst8Aqyd_zwD+Ch@mail.gmail.com>
Date: Tue, 19 Oct 2010 12:04:40 +0300
Message-ID: <AANLkTinSgP_O1H=ZPyP-_yUroY+dDxJLASMH36qeFJcs@mail.gmail.com>
Subject: Re: ESME-291 - replies duplicated in streams and public timeline
From: Vassil Dichev <vdichev@apache.org>
To: esme-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Ah, you mean the link with the conversation? Got it. Let me try to fix this=
.

On Tue, Oct 19, 2010 at 11:30 AM, Richard Hirsch <hirsch.dick@gmail.com> wr=
ote:
> I just deployed vassil's change on stax (
> http://esmecloudserverapache.dickhirsch.staxapps.net/) =A0and the
> conversations don't work any more - they don't show up in the timeline
> :-<
>
>
> On Tue, Oct 19, 2010 at 9:43 AM, Ethan Jewett <esjewett@gmail.com> wrote:
>> Far more sophisticated than the println "instrumentation" I was using. I=
'll
>> keep that in mind for the future. I hadn't paid much attention to the
>> after-hook methods in the MetaMapper until now.
>>
>> Ethan
>>
>> On Tue, Oct 19, 2010 at 9:20 AM, Vassil Dichev <vdichev@apache.org> wrot=
e:
>>
>>> Heh, I added an afterSave handler with Thread.dumpStack to show me
>>> where does the double save occur.
>>>
>>> On Tue, Oct 19, 2010 at 9:49 AM, Ethan Jewett <esjewett@gmail.com> wrot=
e:
>>> > Hi Vassil,
>>> >
>>> > I got as far as confirming the the message ids are different, so it
>>> > looks to me like two messages are created and saved. I then started
>>> > looking for where the second message is created and didn't make any
>>> > progress. My tests seemed to show the the method creation code in
>>> > UserActor was only called once.
>>> >
>>> > If you can find some time to investigate, that would be excellent.
>>> >
>>> > Ethan
>>> >
>>> > On Tuesday, October 19, 2010, Vassil Dichev <vdichev@apache.org> wrot=
e:
>>> >> An action is not likely to create a duplicate message, as even when =
it
>>> >> resends, a new message is never created and the mailbox is checked i=
f
>>> >> such a message exists. I've solved at least 2 duplication bugs so fa=
r
>>> >> and the problem has always been that the same message was visualized
>>> >> twice.
>>> >>
>>> >> The first thing to look for is the id of the message in the page
>>> >> source- if the id is the same, then it's the same message shown twic=
e
>>> >> by the UI.
>>> >>
>>> >> I'd like to take a look at the problem and check if I see an easy
>>> solution.
>>> >>
>>> >> Vassil
>>> >>
>>> >>
>>> >> On Tue, Oct 19, 2010 at 5:32 AM, Richard Hirsch <hirsch.dick@gmail.c=
om>
>>> wrote:
>>> >>> On Mon, Oct 18, 2010 at 7:30 PM, Ethan Jewett <esjewett@gmail.com>
>>> wrote:
>>> >>>> No, I don't think so. I did a clean install locally last week and =
I
>>> only
>>> >>>> have the RSS-pull action set up. It's a ghost in the machine somew=
here
>>> ;-) I
>>> >>>> spent some time tracing through actor messaging paths and I guess =
I'll
>>> just
>>> >>>> need to spend a little more time on it.
>>> >>>>
>>> >>>> An alternative would be to find an SVN check-in that doesn't have =
the
>>> issue
>>> >>>> and then track down the exact change that caused the problem. Not =
sure
>>> which
>>> >>>> will be more difficult ...
>>> >>>
>>> >>> This would probably be a challenge - especially if the problem has
>>> >>> been around for a while.
>>> >>>
>>> >>> D.
>>> >>>>
>>> >>>> Ethan
>>> >>>>
>>> >>>> On Mon, Oct 18, 2010 at 5:51 PM, Richard Hirsch <
>>> hirsch.dick@gmail.com>wrote:
>>> >>>>
>>> >>>>> On Mon, Oct 18, 2010 at 5:41 PM, Ethan Jewett <esjewett@gmail.com=
>
>>> wrote:
>>> >>>>> > Hi all,
>>> >>>>> >
>>> >>>>> > Dick did some testing after my commits today and found a couple=
 of
>>> >>>>> issues.
>>> >>>>> > The first (ESME-290) was that I broke the public timeline. That=
 is
>>> now
>>> >>>>> > fixed.
>>> >>>>> >
>>> >>>>> > The second issue is ESME-291 -
>>> >>>>> > https://issues.apache.org/jira/browse/ESME-291. =A0The problem =
is
>>> that
>>> >>>>> replies
>>> >>>>> > show up duplicated in the streams view and in the public timeli=
ne
>>> view
>>> >>>>> > (though in the public timeline view it is *only* for messages t=
hat
>>> were
>>> >>>>> > created before the public timeline actor started up, so if you
>>> create new
>>> >>>>> > replies you need to restart the server to see them duplicated i=
n
>>> the
>>> >>>>> public
>>> >>>>> > timeline). This is actually an old issue. It exists at least in
>>> release
>>> >>>>> 1.1
>>> >>>>> > and probably well before that.
>>> >>>>> >
>>> >>>>> > The reason this is happening is that when a reply is created th=
ere
>>> are
>>> >>>>> > actually two messages created and persisted to the database. On=
e is
>>> >>>>> created
>>> >>>>> > in the UserActor, which is what is supposed to happen. But anot=
her
>>> >>>>> message
>>> >>>>> > is created somewhere else and I can't figure out where! Any ide=
as?
>>> >>>>>
>>> >>>>> Some action maybe?
>>> >>>>>
>>> >>>>> Maybe Vassil has an idea.
>>> >>>>> >
>>> >>>>> > Ethan
>>> >>>>> >
>>> >>>>>
>>> >>>>
>>> >>>
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Twitter: http://twitter.com/vdichev
>>> >> Blog: http://speaking-my-language.blogspot.com
>>> >>
>>> >
>>>
>>>
>>>
>>> --
>>> Twitter: http://twitter.com/vdichev
>>> Blog: http://speaking-my-language.blogspot.com
>>>
>>
>


--=20
Twitter: http://twitter.com/vdichev
Blog: http://speaking-my-language.blogspot.com