esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Hirsch <hirsch.d...@gmail.com>
Subject Re: ESME - 266 - my fix in progress, hopefully...
Date Thu, 02 Sep 2010 13:56:00 GMT
Thanks

On Thu, Sep 2, 2010 at 3:46 PM, Vassil Dichev <vdichev@apache.org> wrote:
> Sorry folks, it was my fault. I had some time to check the commit and
> found the problem and will fix it shortly.
>
> Vassil
>
>
> On Thu, Sep 2, 2010 at 12:04 PM, Vassil Dichev <vdichev@apache.org> wrote:
>> Yeah, but if I remember correctly it was already commented before that.
>>
>> On Thu, Sep 2, 2010 at 11:48 AM, Imtiaz Ahmed H E <in.imtiaz@gmail.com> wrote:
>>> Rev 932954 has the getEntries call.
>>>
>>> Vassil's check-in of rev 955728 removed it.
>>>
>>> Looking into it.
>>>
>>> Imtiaz
>>>
>>> ----- Original Message ----- From: "Vassil Dichev" <vdichev@apache.org>
>>> To: <esme-dev@incubator.apache.org>
>>> Sent: Thursday, September 02, 2010 2:06 PM
>>> Subject: Re: ESME - 266 - my fix in progress, hopefully...
>>>
>>>
>>>> I think I see where the problem is. In Feed.scala there's some code
>>>> which loops through all the entries, the problem is that it should do
>>>> this using the getEntries method. It's overriden in both RssFeed.scala
>>>> and AtomFeed.scala, but it's not called anywhere.
>>>>
>>>> I think it was chucked in some of the last refactorings. Check the
>>>> history and you have the answer.
>>>>
>>>> Vassil
>>>>
>>>>
>>>> On Thu, Sep 2, 2010 at 10:45 AM, Ethan Jewett <esjewett@gmail.com>
wrote:
>>>>>
>>>>> On Thu, Sep 2, 2010 at 8:33 AM, Vassil Dichev <vdichev@apache.org>
wrote:
>>>>>>
>>>>>> There's something I don't understand, why are you using the search
>>>>>> timeline instead of the standard API, e.g.
>>>>>>
>>>>>> http://twitter.com/statuses/user_timeline/esjewett.atom
>>>>>
>>>>> Hmmm, I'm not sure. I just originally had it set up as the search
>>>>> timeline and then it stopped working.
>>>>>
>>>>>> Does it work with this?
>>>>>
>>>>> I'll try, hopefully later today.
>>>>>
>>>>>> Also, I don't understand the Jira description- does it put the whole
>>>>>> content of the search page as one tweet?
>>>>>
>>>>> No, you and Imtiaz are right: the Jira description is misleading. At
>>>>> most it puts part of the page into the ESME message. I'm beginning to
>>>>> think that it's actually putting the title of the page into the
>>>>> message. Really not sure.
>>>>>
>>>>> Ethan
>>>>>
>>>
>>>
>>
>

Mime
View raw message