esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Hirsch <hirsch.d...@gmail.com>
Subject Re: 208 Fixed ! - Re: Release 1.1 issues I am closing due to work done on them
Date Wed, 25 Aug 2010 10:02:11 GMT
Thanks.

While I was testing actions today, I found a few other little bugs.
I've added them to the JIRA under the 1.1 Release.
I'd like to just add bugs to the 1.1 release version - everything else
goes into the backlog.

D.


On Wed, Aug 25, 2010 at 7:09 AM, Imtiaz Ahmed H E <in.imtiaz@gmail.com> wrote:
> Please find attached to the Jira, EsmeJira208FixPatch.diff.
>
> Please exclude the pubsubhibub-2 branch changes when you apply the patch.
> CAVEAT: I have tried the fix only on the home page, but believe have fixed
> it everywhere (its identical everywhere), please do verify that before
> committing.
>
> Imtiaz
>
> ----- Original Message ----- From: "Richard Hirsch" <hirsch.dick@gmail.com>
> To: <esme-dev@incubator.apache.org>
> Sent: Tuesday, August 24, 2010 9:56 AM
> Subject: Re: Release 1.1 issues I am closing due to work done on them
>
>
> The idea is that you resend the message to your followers - sort of
> like a retweet in Twitter. Once you have resent a message, then it
> can't be resent by you again and therefore, the "resend" link for that
> message disappears from your timeline. If you refresh the entire
> browser, you will see the message under "popular messages" on the main
> screen.
>
> The functionality works with FF but doesn't work with IE.  It would be
> interesting to see whether the msg_id value is filled in the scala
> code when calling from IE or whether the problem is somewhere else.
>
> D.
>
> On Tue, Aug 24, 2010 at 5:58 AM, Imtiaz Ahmed H E <in.imtiaz@gmail.com>
> wrote:
>>
>> And, when I logout, close the Web UI, open it again and login, the link
>> 'resend' doesn't show on the messages for which I had clcked 'resend'
>> before
>> logout.
>>
>> Please clarify...
>>
>> Imtiaz
>>
>> ----- Original Message ----- From: "Imtiaz Ahmed H E"
>> <in.imtiaz@gmail.com>
>> To: <esme-dev@incubator.apache.org>
>> Sent: Tuesday, August 24, 2010 9:20 AM
>> Subject: Re: Release 1.1 issues I am closing due to work done on them
>>
>>
>>> Dick,
>>>
>>> What should happen when I click 'resend' ?
>>>
>>> I tried it and the 'resend' link disappears, that's all that happens,
>>> when
>>> I click resend.
>>>
>>> Imtiaz
>>>
>>> ----- Original Message ----- From: "Richard Hirsch"
>>> <hirsch.dick@gmail.com>
>>> To: <esme-dev@incubator.apache.org>
>>> Sent: Tuesday, August 24, 2010 8:55 AM
>>> Subject: Re: Release 1.1 issues I am closing due to work done on them
>>>
>>>
>>>> Looks great.
>>>>
>>>> 2 of the issues are IE7-related and are assigned to Anne but she is
>>>> currently in India and probably doesn't have a lot of time.
>>>>
>>>> https://issues.apache.org/jira/browse/ESME-208 might be scala-based
>>>> since it looks like it makes an ajax call:
>>>>
>>>> function resend_msg(msg_id) {
>>>> F341169038678G4R({'command': "resend", 'params':{"msg_id": msg_id}});
>>>> }
>>>>
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/scala/org/apache/esme/snippet/UserSnip.scala?view=markup
>>>>
>>>> object JsonResender extends JsonHandler{
>>>> 83 def apply(in: Any): JsCmd = in match {
>>>> 84 case JsonCmd("resend", _, map: Map[String, Any], _) =>
>>>> 85 for (msgId <- map.get("msg_id").map(toLong);
>>>> 86 user <- User.currentUser)
>>>> 87 Distributor ! Distributor.ResendMessage(user.id, msgId)
>>>> 88
>>>> 89 Noop
>>>> 90
>>>> 91 case _ => Noop
>>>> 92 }
>>>> 93 }
>>>>
>>>>
>>>> On Tue, Aug 24, 2010 at 1:06 AM, Ethan Jewett <esjewett@gmail.com>
>>>> wrote:
>>>>>
>>>>> This is all done, leaving us with a grand total of three issues left
>>>>> in the Release 1.1 queue! :-)
>>>>>
>>>>>
>>>>>
>>>>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&sorter/order=DESC&sorter/field=priority&resolution=-1&pid=12310850&fixfor=12314823
>>>>>
>>>>> Ethan
>>>>>
>>>>> On Mon, Aug 23, 2010 at 2:12 PM, Richard Hirsch <hirsch.dick@gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> I ju
>>>>>>
>>>>>> On Mon, Aug 23, 2010 at 9:01 PM, Ethan Jewett <esjewett@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> I'm going to close down several release 1.1 issues that I think
are
>>>>>>> resolved, mostly due to patches by Imtiaz. If anyone else would
like
>>>>>>> to take a look, links to the issues are below:
>>>>>>>
>>>>>>> ESME-212 - Messages from pools aren't hidden -
>>>>>>> https://issues.apache.org/jira/browse/ESME-212
>>>>>>> ESME-205 - Search is broken -
>>>>>>> https://issues.apache.org/jira/browse/ESME-205
>>>>>>> ESME-242 - The use of metadata in the api2 currently doesn't
work -
>>>>>>> https://issues.apache.org/jira/browse/ESME-242
>>>>>>> ESME-259 - Pool selector in streams doesn't work anymore -
>>>>>>> https://issues.apache.org/jira/browse/ESME-259
>>>>>>
>>>>>> OK - I haven't tried out the search on Stax but I will do it tomorrow
>>>>>> - hopefully.
>>>>>>>
>>>>>>> We also don't really need ESME-225 in release 1.1, as it is a
unit
>>>>>>> test, so I'll move that to the backlog.
>>>>>>
>>>>>> Agreed
>>>>>>
>>>>>>>
>>>>>>> I'll leave these for the next few hours, so feel free to speak
up
>>>>>>> now.
>>>>>>> After that I'm going to change the issue status, but they can
be
>>>>>>> changed back if necessary.
>>>>>>
>>>>>> I just closed ESME-240 - it was my fault that I used wrong syntax
- we
>>>>>> should probably document actions better
>>>>>>
>>>>>>>
>>>>>>> Ethan
>>>>>>>
>>>>>>
>>>>>
>>>
>>
>>
>
>

Mime
View raw message