Return-Path: 
 <esme-dev-return-3033-apmail-incubator-esme-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-esme-dev-archive@minotaur.apache.org
Received: (qmail 15706 invoked from network); 16 Feb 2010 16:28:55 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 16 Feb 2010 16:28:54 -0000
Received: (qmail 76652 invoked by uid 500); 16 Feb 2010 16:28:54 -0000
Delivered-To: apmail-incubator-esme-dev-archive@incubator.apache.org
Received: (qmail 76614 invoked by uid 500); 16 Feb 2010 16:28:54 -0000
Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:esme-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:esme-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:esme-dev@incubator.apache.org>
List-Id: <esme-dev.incubator.apache.org>
Reply-To: esme-dev@incubator.apache.org
Delivered-To: mailing list esme-dev@incubator.apache.org
Received: (qmail 76413 invoked by uid 99); 16 Feb 2010 16:28:53 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Feb 2010 16:28:53 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9)
    by apache.org (qpsmtpd/0.29) with SMTP; Tue, 16 Feb 2010 16:28:45 +0000
Received: (qmail 15438 invoked by uid 99); 16 Feb 2010 16:28:25 -0000
Received: from localhost.apache.org (HELO mail-fx0-f210.google.com)
 (127.0.0.1)
  (smtp-auth username bdelacretaz, mechanism plain)
  by minotaur.apache.org (qpsmtpd/0.29) with ESMTP;
 Tue, 16 Feb 2010 16:28:25 +0000
Received: by fxm2 with SMTP id 2so159871fxm.27
        for <multiple recipients>; Tue, 16 Feb 2010 08:28:22 -0800 (PST)
MIME-Version: 1.0
Received: by 10.223.100.216 with SMTP id z24mr8198843fan.5.1266337702133;
 Tue,
	16 Feb 2010 08:28:22 -0800 (PST)
In-Reply-To: <fa2d9f451002150705u6d749c25g6c5b5a295f04d6a7@mail.gmail.com>
References: <fa2d9f451002150705u6d749c25g6c5b5a295f04d6a7@mail.gmail.com>
Date: Tue, 16 Feb 2010 17:28:22 +0100
Message-ID: <f767f0601002160828w652f1d81pdc79dc4da29dc0da@mail.gmail.com>
Subject: Re: [VOTE] Approve the release of apache-esme-incubating-1.0
From: Bertrand Delacretaz <bdelacretaz@apache.org>
To: esme-dev@incubator.apache.org
Cc: general@incubator.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Feb 15, 2010 at 4:05 PM, Richard Hirsch <hirsch.dick@gmail.com> wro=
te:
> ...The candidate can be found at:
> =C2=A0http://people.apache.org/~rhirsch/esme/

Unfortunately I'm -1 on the release, I have a few issues including a
GPL dependency.

1) jwebunit dependency is GPL
The server module depends on

net.sourceforge.jwebunit:jwebunit-htmlunit-plugin:jar:1.4.1:test

which according to http://jwebunit.sourceforge.net/license.html is GPL.

2) The sha1 digest does not match, did I do something wrong?

$ openssl sha1 apache-esme-incubating-1.0-src.tar.gz
SHA1(apache-esme-incubating-1.0-src.tar.gz)=3D
a9ec8d95266d5944d493392a06eb1651c03222f1

$ cat apache-esme-incubating-1.0-src.tar.gz.sha
apache-esme-incubating-1.0-src.tar.gz: A53494C8 55474CE3 5AC20516 C2448CB6
                                       64B3B76C 747BA64A FFC9A836 EDAB8D86
                                       4E0735CC AA29ACA9 07767C58 D1C0FEDA
                                       CA7E73A3 ADA3944D 464314B2 4BE0E476

3) mvn dependency:analyze of the server module shows lots of unused
declared dependencies, those should be cleaned up, especially
openDMK:jdmkrt:jar which according to https://opendmk.dev.java.net/ is
either GPL or CDDL license. Not sure which parts of OpenDMK are which
license, but as it's unused better remove it.

4) When trying to build esme-java-client with "mvn clean install" I
get "Embedded error: Error while executing the external compiler" if
JAVA_HOME is not set.

5) apache-esme-incubating-1.0-src.tar.gz contains .svn folders, it
should not have that. You could have created the release using svn
export of http://svn.apache.org/repos/asf/incubator/esme/tags/apache-esme-1=
.0-incubating/
to avoid that.

6) I couldn't find license information for the
com.twitter:stats:jar:1.3:compile dependency, was that checked to be
ok?

Sorry that I didn't have time to look at that during the ESME podling vote.

Apart from the GPL dependency the release preparation looks mostly ok,
rat reports are good, license/notice are provided, etc.

-Bertrand