Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: esme-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of hirsch.dick@gmail.com
 designates 209.85.220.209 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=lY1dI3vmFWYXjNnM//NZzWAMS/k3VjJ7qqZdxF7FQZmmHbpF8PMdxA8cB2Uqm3/BN1
         10Q3jNT8aLD4mhjCPZoKm4JrHJq+6u22hN1z5LOypPFrgDdGTbNLzTxgqyfG9CwK545j
         q6pz/tJl8zOymxNdVb22fDq/4aLRqyI2pRgKM=
MIME-Version: 1.0
In-Reply-To: <fa2d9f450910010946l757ea4f9o41379d45866ab310@mail.gmail.com>
References: <fa2d9f450909280550x64d90c97jaa4ed89b1b74ff60@mail.gmail.com>
	 <32D4E536-BC64-4F09-B40E-C5C07B07B3BF@davebsoft.com>
	 <fa2d9f450909302152o7d57f2f9sd60d1d9280f0c8b4@mail.gmail.com>
	 <F119C1C2-6C9D-47A7-BFBA-0CA66871E444@davebsoft.com>
	 <67FDA7CF-14FB-4D0D-927B-B67381F6FDFA@davebsoft.com>
	 <c7fc82820910010149g79d102b6m84ffe18906be9c66@mail.gmail.com>
	 <8DE647E4-B047-4DEA-8658-E435252141E5@davebsoft.com>
	 <c7fc82820910010214h2e93ce2asce8720de4febff2f@mail.gmail.com>
	 <fa2d9f450910010242m62d62850lb8cd27dcb5236815@mail.gmail.com>
	 <fa2d9f450910010946l757ea4f9o41379d45866ab310@mail.gmail.com>
Date: Fri, 2 Oct 2009 10:57:21 +0200
Message-ID: <fa2d9f450910020157y76210967k28506cf98fc1292e@mail.gmail.com>
Subject: Re: New Jira item for user list page
From: Richard Hirsch <hirsch.dick@gmail.com>
To: esme-dev@incubator.apache.org
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Committed the code from your patch and deployed it on stax.

Would you like to try my a new patch based on Vassil's suggestions and
my comments on the JIRA item?

D.

On Thu, Oct 1, 2009 at 6:46 PM, Richard Hirsch <hirsch.dick@gmail.com> wrot=
e:
> @Dave - I'll do a test deployment tomorrow with the files from the
> Jira item. =A0Then, I'll probably do a commit just to keep things
> rolling. Afterwards, Vassil and you can sit down and figure out how to
> improve the code.
>
> P.S. I like the fact that you are getting rid of the code that is
> commented-out. You are right - that stuff really doesn't belong in the
> code base - that is why we have SVN.
>
> D.
>
> On Thu, Oct 1, 2009 at 11:42 AM, Richard Hirsch <hirsch.dick@gmail.com> w=
rote:
>> @Dave: do you want me to make a commit/deployment based on the first
>> version of code or do you want to make a new version based on vassil's
>> suggestions and then I'll make a commit?
>>
>> Or both :->
>>
>> D.
>>
>> On Thu, Oct 1, 2009 at 11:14 AM, Vassil Dichev <vdichev@apache.org> wrot=
e:
>>> Yes, sorry, I'm being myopic today. In that case, as a matter of
>>> personal preference, I don't very much like using _1, _2, etc. for
>>> tuples. Extracting values to meaningful variable names seems more
>>> readable. For instance, on line 61, instead of
>>>
>>> =A0 =A0 =A0 =A0 =A0 val msg =3D lastMessage(u.id)
>>>
>>> you could do
>>>
>>> =A0 =A0 =A0 =A0 =A0 val (m, when) =3D lastMessage(u.id)
>>>
>>> and lines 77-78, instead of
>>>
>>> =A0 =A0 =A0case msgs =3D> {
>>> =A0 =A0 =A0 =A0val msg =3D msgs(0)._1
>>>
>>> I would prefer
>>>
>>> =A0 =A0 =A0case (msg, _) :: _ =3D> {
>>>
>>> Does that read better?
>>>
>>> Vassil
>>>
>>>
>>> On Thu, Oct 1, 2009 at 12:01 PM, Dave Briccetti <daveb@davebsoft.com> w=
rote:
>>>> No, the UserView is no longer used for this page. I just deleted part =
of it.
>>>> I didn=92t write anything. The new Scala code is in UserMgr. The video
>>>> explains, and you could probably fast-forward or skip through it.
>>>>
>>>> On Oct 1, 2009, at 1:49 AM, Vassil Dichev wrote:
>>>>
>>>>> Apart from the fact that xml is coded in the UserView, it looks very
>>>>> good. I especially like the pattern to destructure a tuple into vals
>>>>> using case:
>>>>>
>>>>> map{
>>>>> =A0case (m, idx) =3D>...
>>>>>
>>>>> Quite readable.
>>>>>
>>>>>
>>>>> On Thu, Oct 1, 2009 at 11:16 AM, Dave Briccetti <daveb@davebsoft.com>
>>>>> wrote:
>>>>>>
>>>>>> Patch file and new files (see video for explanation), for review:
>>>>>>
>>>>>> https://issues.apache.org/jira/secure/attachment/12420990/esme-86.zi=
p
>>>>>>
>>>>>>
>>>>
>>>>
>>>
>>
>