Return-Path: Delivered-To: apmail-incubator-esme-dev-archive@minotaur.apache.org Received: (qmail 89301 invoked from network); 30 Sep 2009 03:47:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 30 Sep 2009 03:47:37 -0000 Received: (qmail 29575 invoked by uid 500); 30 Sep 2009 03:47:37 -0000 Delivered-To: apmail-incubator-esme-dev-archive@incubator.apache.org Received: (qmail 29524 invoked by uid 500); 30 Sep 2009 03:47:36 -0000 Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: esme-dev@incubator.apache.org Delivered-To: mailing list esme-dev@incubator.apache.org Received: (qmail 29512 invoked by uid 99); 30 Sep 2009 03:47:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2009 03:47:36 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of benewu@gmail.com designates 209.85.210.174 as permitted sender) Received: from [209.85.210.174] (HELO mail-yx0-f174.google.com) (209.85.210.174) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2009 03:47:27 +0000 Received: by yxe4 with SMTP id 4so628856yxe.32 for ; Tue, 29 Sep 2009 20:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=SlcaacLRt5oh9Z2SxsWm/ezvTrZUsIcvBPe5n0Cvc+k=; b=KoiRLKBWHPr72H5BgPJN2PKzaReTXsVgMfmKSrYGRFd71KogQ2JNphIIMcldIaun0U eDERNdpG4U2SfQLsBUHG/M6DtjJ4Q8v1w26VzYS28HXMEyH5ROIZSXmz0CCwbilYCjlW wvfqhrVNHez4Di+IIZ6hC4PBCuIUbA0Vdz284= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=cg6DBaxgaJ1YGWaJHwU1U6ArnSLBsIXSxV0vt+msieE0NY91mtb5/6oIcz2iH25N0v Ir7vKL5wyH8f0sXHf9tfVbRuvWDPxhLTjT2HKEo8Wxzvaw0ECNKuZIDB+JMiYlNZa/Ej HwFyPlLXIwQrIGG/SYy4epvnicinn9pgSlTuQ= MIME-Version: 1.0 Received: by 10.100.235.21 with SMTP id i21mr5667554anh.96.1254282426218; Tue, 29 Sep 2009 20:47:06 -0700 (PDT) In-Reply-To: References: <4db64d890909272201oc8819dewb576338212e3fb78@mail.gmail.com> <4db64d890909280406v7d80a0d7s8d1efda0d44c28f7@mail.gmail.com> <4db64d890909280521v3366d08fx1e4faf720417c3b3@mail.gmail.com> <4db64d890909280748j17cd0590n8a11b4ec1b9f3f67@mail.gmail.com> <4db64d890909290049s3da3482akd609db69f35a78ea@mail.gmail.com> Date: Wed, 30 Sep 2009 11:47:06 +0800 Message-ID: <4db64d890909292047r7e25cbb8xa04d1dff8be25294@mail.gmail.com> Subject: Re: [New Contributor]Where do I submit patch? From: Xuefeng Wu To: esme-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=001636b2b4897679910474c36242 X-Virus-Checked: Checked by ClamAV on apache.org --001636b2b4897679910474c36242 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi org.apache.esme.model.User is not extends or with from MegaProtoUser/ MetaMegaProtoUser. Lift implement user management by view, Maybe we could learn from it or reuse it. On Tue, Sep 29, 2009 at 9:36 PM, Richard Hirsch wrot= e: > Committed your patches. Thanks - looks great. > > I'm having trouble creating JIRA items, so I'll describe it first and > create the Jira item later. > > Why don't you take a look at the sign-up page. I've redone the bottom > part of the web ui but I can't change the formatting for the part > labeled "Basic User Information" (email, password, etc.) . Could you > try and dig out where this is? Look at the file > "trunk\server\src\main\webapp\sign-up.html" for details. The code that > creates the fields is buried somewhere either in the ESME scala or > deeper in the lift scala code. Irregardless it is ugly and I'd love to > change it. > >
>
ui_sign_up_basic_info >
> >
>
> > D. > > On Tue, Sep 29, 2009 at 9:49 AM, Xuefeng Wu wrote: > > I submitted patch for ESME-84Could you help to test it with the patch f= or > > ESME-72? > > > > And is there any issue I could contribute? > > > > On Tue, Sep 29, 2009 at 3:44 PM, Vassil Dichev > wrote: > > > >> Could you just send a diff file, because it's hard to see what the > >> changes are when code's simply pasted in the mail body. > >> > >> Thanks! > >> > >> > >> On Mon, Sep 28, 2009 at 5:48 PM, Xuefeng Wu wrote: > >> > Hi Richard, > >> > I'm sorry that I get some trouble when do ESME-84. > >> > *Could anybody help to finish this task?* > >> > > >> > I added some code in AccessPoolMgr. displayPoolUsers. > >> > I know it's ugly. :( > >> > > >> > def displayPoolUsers(in: NodeSeq): NodeSeq =3D { > >> > // get the span name to update > >> > val spanName =3D S.attr("the_id") openOr "PoolSpan" > >> > // get the current user > >> > val user =3D User.currentUser > >> > > >> > def doRender(): NodeSeq =3D > >> > Privilege.findAll(By(Privilege.pool, poolId.is)) match { > >> > case Nil =3D> NodeSeq.Empty > >> > case xs =3D> { > >> > bind("pool", in, > >> > "user" -> > >> > (lst =3D> xs.flatMap(i =3D> bind("user", lst, > >> > "name" -> > >> > User.find(i.user).map( > >> > _. > >> nickname.is > >> > ).getOrElse(""), > >> > "privilege" -> > >> > i.permission.is.toString > >> > )))) > >> > } > >> > } > >> > def updateSpan(): JsCmd =3D SetHtml(spanName, doRender()) > >> > > >> > val poolDetailSpanName =3D S.attr("the_detail_id") openOr > >> "poolDetailSpan" > >> > def doPoolDetailRender():NodeSeq =3D AccessPool.find(poolId.is) m= atch > { > >> > case Full(ap) =3D> bind( > >> > "pool", in, > >> > "name" -> ap.getName, > >> > "createdDate" -> ap.createdDate) > >> > case _ =3D> NodeSeq.Empty > >> > } > >> > def updatePoolDetailSpan(): JsCmd =3D SetHtml(poolDetailSpanName, > >> > doPoolDetailRender()) > >> > > >> > def updateAllSpan():JsCmd =3D SetHtml(spanName, doRender()) & > JsRaw(";") > >> & > >> > SetHtml(poolDetailSpanName, doPoolDetailRender()) > >> > updatePool.set(updateAllSpan) > >> > doRender > >> > } > >> > > >> > > >> > And modify pools_view/index.html > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > > >> >
Name CreateDate
> >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > > >> >
Name CreateDate
> >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > > >> > > >> >
User Privilege
> >> > > >> > > >> > > >> > > >> > It's so ugly and It's work on Chrome and Safari, but do not work on > >> Firefox! > >> > > >> > > >> > The response is : > >> > > >> > try{jQuery("#PoolSpan").each(function(i) {this.innerHTML =3D "\u000a > >> > \u000a \u000a > >> > \u000a \u000a > >> > \u000a > >> > \u000a > >> > \u000a
NameCreateDate
\u000a \u000a \u000a > >> > \u000a > >> > \u000a \u000a \u000a \u000a > >> > \u000a > >> > \u000a \u000a \u000a
User Privilege
admin Admin
\u000= a > >> > ";});} catch (e) {};;try{jQuery("#poolDetailSpan").each(function(i) > >> > {this.innerHTML =3D "\u000a \u000a \u000a > >> > \u000a > >> > \u000a \u000a > >> > \u000a \u000a > >> >
Name CreateDate
liftMon, 28 Sep 2009 09:23:30 UTC
\u000a \u000a \u000a \u000a > >> > \u000a > >> > \u000a \u000a \u000a > >> > \u000a > >> > \u000a > >> > \u000a \u000a
User Privilege
\u000a ";})= ;} > >> > catch (e) {} > >> > > >> > > >> > > >> > On Mon, Sep 28, 2009 at 8:40 PM, Richard Hirsch < > hirsch.dick@gmail.com > >> >wrote: > >> > > >> >> I'll wait to add your ESME-72 code until you have finished the > >> >> ESME-84-related code. Otherwise, I wouldn't be able to test it. > >> >> > >> >> D. > >> >> > >> >> On Mon, Sep 28, 2009 at 2:21 PM, Xuefeng Wu > wrote: > >> >> > Thank you > >> >> > > >> >> > On Mon, Sep 28, 2009 at 7:42 PM, Vassil Dichev > > >> >> wrote: > >> >> > > >> >> >> First of all, welcome to the team, Xuefeng! I hope you have fun. > >> >> >> > >> >> >> Yes, AccessPoolMgr is the right place to check and edit (Dick, > you're > >> >> >> getting better with Scala!) > >> >> >> > >> >> >> Good luck, > >> >> >> Vassil > >> >> >> > >> >> >> > >> >> >> On Mon, Sep 28, 2009 at 2:22 PM, Richard Hirsch < > >> hirsch.dick@gmail.com> > >> >> >> wrote: > >> >> >> > Yes take a look at "displayPoolUsers" in AccessPoolMgr. > >> >> >> > > >> >> >> > D. > >> >> >> > > >> >> >> > On Mon, Sep 28, 2009 at 1:06 PM, Xuefeng Wu > >> wrote: > >> >> >> >> The poolUsers snippet code is in AccessPoolMgr? > >> >> >> >> > >> >> >> >> On Mon, Sep 28, 2009 at 6:56 PM, Richard Hirsch < > >> >> hirsch.dick@gmail.com > >> >> >> >wrote: > >> >> >> >> > >> >> >> >>> Part of the code is here: > >> >> >> >>> trunk\server\src\main\webapp\pools_view\index.html. > >> >> >> >>> > >> >> >> >>> Currently, the users for the poor are being added with this > code: > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>> > > >> >> > >> >> >> >>> > >> >> >> >>> > >> >> >> >>>
User Privilege
> >> >> >> >>> > >> >> >> >>> You have to have something similar (change HTML file and Sca= la > >> code > >> >> >> >>> for the pool details. > >> >> >> >>> > >> >> >> >>> D. > >> >> >> >>> > >> >> >> >>> On Mon, Sep 28, 2009 at 12:52 PM, Xuefeng Wu < > benewu@gmail.com> > >> >> wrote: > >> >> >> >>> > I think so, but I'm not sure which view for AccessPool. > >> >> >> >>> > org.apache.esme.view.UserView? > >> >> >> >>> > > >> >> >> >>> > On Mon, Sep 28, 2009 at 6:43 PM, Richard Hirsch < > >> >> >> hirsch.dick@gmail.com > >> >> >> >>> >wrote: > >> >> >> >>> > > >> >> >> >>> >> There is already a view for the AccesPools. I'd try to us= e > >> that > >> >> as > >> >> >> >>> >> much as possible rather than putting any UI-related code = in > >> the > >> >> >> >>> >> AccessPoolMgr. > >> >> >> >>> >> > >> >> >> >>> >> @vassil: what do you think? > >> >> >> >>> >> > >> >> >> >>> >> D. > >> >> >> >>> >> > >> >> >> >>> >> On Mon, Sep 28, 2009 at 11:42 AM, Xuefeng Wu < > >> benewu@gmail.com> > >> >> >> wrote: > >> >> >> >>> >> > Maybe I find it.Should I place code at > >> >> >> >>> org.apache.esme.lib.AccessPoolMgr? > >> >> >> >>> >> > > >> >> >> >>> >> > On Mon, Sep 28, 2009 at 5:38 PM, Xuefeng Wu < > >> benewu@gmail.com> > >> >> >> wrote: > >> >> >> >>> >> > > >> >> >> >>> >> >> Should we have a new snippet or view for AcessPool=EF= =BC=9F > >> >> >> >>> >> >> I'm not sure where could place the bind code for displ= ay > >> >> >> AcessPoll > >> >> >> >>> >> detail. > >> >> >> >>> >> >> > >> >> >> >>> >> >> > >> >> >> >>> >> >> P.S. I submit a new patch for ESME-72, please replay t= he > >> new > >> >> one > >> >> >> if > >> >> >> >>> you > >> >> >> >>> >> >> download before, and I deleted the old patch file for > >> >> ignoring > >> >> >> >>> confuse. > >> >> >> >>> >> >> > >> >> >> >>> >> >> > >> >> >> >>> >> >> On Mon, Sep 28, 2009 at 3:14 PM, Richard Hirsch < > >> >> >> >>> hirsch.dick@gmail.com > >> >> >> >>> >> >wrote: > >> >> >> >>> >> >> > >> >> >> >>> >> >>> Looks good. > >> >> >> >>> >> >>> > >> >> >> >>> >> >>> I'll test it on the stax deployment. > >> >> >> >>> >> >>> > >> >> >> >>> >> >>> I've added a new JIRA item > >> >> >> >>> >> >>> (https://issues.apache.org/jira/browse/ESME-84) to > >> display > >> >> the > >> >> >> new > >> >> >> >>> >> >>> values in the UI. Why don't you take a crack at them. > It > >> >> doesn't > >> >> >> ave > >> >> >> >>> >> >>> to be pretty (that will come later) just functional. > >> >> >> >>> >> >>> > >> >> >> >>> >> >>> D. > >> >> >> >>> >> >>> > >> >> >> >>> >> >>> On Mon, Sep 28, 2009 at 8:14 AM, Xuefeng Wu < > >> >> benewu@gmail.com> > >> >> >> >>> wrote: > >> >> >> >>> >> >>> > Thank you ! > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > I'm in Shanghai now. > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > On Mon, Sep 28, 2009 at 1:58 PM, J Aaron Farr < > >> >> >> farra@apache.org> > >> >> >> >>> >> wrote: > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> >> On Mon 28 Sep 2009 13:01, Xuefeng Wu < > benewu@gmail.com > >> > > >> >> >> wrote: > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> > I write some code for ESME-72, but I don't know > where > >> >> >> should I > >> >> >> >>> >> >>> submit? > >> >> >> >>> >> >>> >> > > >> >> >> >>> >> >>> >> > The attachment is the patch file, Thanks! > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> 0. If you don't have a JIRA account, create one > here: > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> > >> >> https://issues.apache.org/jira/secure/Signup!default.jspa > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> 1. Go to the ESME-72 issue page: > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> https://issues.apache.org/jira/browse/ESME-72 > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> 2. Click the "Attach file to this issue" link on t= he > >> left > >> >> >> side. > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> 3. Attach your patch, include a comment, make sure > you > >> >> click: > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> "Grant license to ASF for inclusion in ASF works > (as > >> per > >> >> >> the > >> >> >> >>> >> Apache > >> >> >> >>> >> >>> >> License =C2=A75)" > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> If you have any trouble, please let us know. > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> Where are you in China? I'm currently in Guangzho= u. > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> >> -- > >> >> >> >>> >> >>> >> J. Aaron Farr > >> >> >> >>> >> >>> >> =E9=A6=AE=E5=82=91=E4=BB=81 > >> >> >> >>> >> >>> >> www.cubiclemuses.com > >> >> >> >>> >> >>> >> > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > -- > >> >> >> >>> >> >>> > Global R&D Center,Shanghai China,Carestream Health, > Inc. > >> >> >> >>> >> >>> > Tel:(86-21)3852 6101 > >> >> >> >>> >> >>> > > >> >> >> >>> >> >>> > >> >> >> >>> >> >> > >> >> >> >>> >> >> > >> >> >> >>> >> >> > >> >> >> >>> >> >> -- > >> >> >> >>> >> >> Global R&D Center,Shanghai China,Carestream Health, In= c. > >> >> >> >>> >> >> Tel:(86-21)3852 6101 > >> >> >> >>> >> >> > >> >> >> >>> >> > > >> >> >> >>> >> > > >> >> >> >>> >> > > >> >> >> >>> >> > -- > >> >> >> >>> >> > Global R&D Center,Shanghai China,Carestream Health, Inc= . > >> >> >> >>> >> > Tel:(86-21)3852 6101 > >> >> >> >>> >> > > >> >> >> >>> >> > >> >> >> >>> > > >> >> >> >>> > > >> >> >> >>> > > >> >> >> >>> > -- > >> >> >> >>> > Global R&D Center,Shanghai China,Carestream Health, Inc. > >> >> >> >>> > Tel:(86-21)3852 6101 > >> >> >> >>> > > >> >> >> >>> > >> >> >> >> > >> >> >> >> > >> >> >> >> > >> >> >> >> -- > >> >> >> >> Global R&D Center,Shanghai China,Carestream Health, Inc. > >> >> >> >> Tel:(86-21)3852 6101 > >> >> >> >> > >> >> >> > > >> >> >> > >> >> > > >> >> > > >> >> > > >> >> > -- > >> >> > Global R&D Center,Shanghai China,Carestream Health, Inc. > >> >> > Tel:(86-21)3852 6101 > >> >> > > >> >> > >> > > >> > > >> > > >> > -- > >> > Global R&D Center,Shanghai China,Carestream Health, Inc. > >> > Tel:(86-21)3852 6101 > >> > > >> > > > > > > > > -- > > Global R&D Center,Shanghai China,Carestream Health, Inc. > > Tel:(86-21)3852 6101 > > > --=20 Global R&D Center,Shanghai China,Carestream Health, Inc. Tel:(86-21)3852 6101 --001636b2b4897679910474c36242--