empire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaun Forbes (JIRA)" <empire-db-...@incubator.apache.org>
Subject [jira] [Created] (EMPIREDB-263) Not possible to set skipRows unless limitRows is also set
Date Wed, 27 Sep 2017 01:06:00 GMT
Shaun Forbes created EMPIREDB-263:

             Summary: Not possible to set skipRows unless limitRows is also set
                 Key: EMPIREDB-263
                 URL: https://issues.apache.org/jira/browse/EMPIREDB-263
             Project: Empire-DB
          Issue Type: Bug
          Components: Core
    Affects Versions: empire-db-2.4.6
            Reporter: Shaun Forbes
            Priority: Minor

For databases that support skipRows() and limitRows() when generating a select statement if
limitRows hasn't been specified then skipRows isn't checked.

In Postgres at least it's legal to specify an offset without also specifying a limit, but
because Empire-db won't apply the offset unless you also specify a limit it's not possible
to generate a select statement with just an offset.

I understand that the two are generally used together, and I only found this because of a
bug in my code, but I don't see a reason why utilizing skipRows() should not be allowed without
limitRows(). Unfortunately, it means that the semantics of clearLimit() may need to change
since it currently clears both and there's no clearSkip() method.

This message was sent by Atlassian JIRA

View raw message